[Bug]: Email template sent when a reviewer asks a developer for more information is incorrect

[abyrne-moz]

What happened?

When an add-ons reviewer uses the review tools to communicate with a developer for a review, the email that is sent to the developer incorrectly states "A reviewer at addons.mozilla.org found an issue"

https://github.com/mozilla/addons-server/blob/3e10c2fc798800169b69493de3a916126f637626/src/olympia/activity/templates/activity/emails/from_reviewer.txt#L11

What did you expect to happen?

The template should be updated as follows:

Hello,

A reviewer at addons.mozilla.org is contacting you regarding version {{ number }} of the add-on {{ name }}. You are receiving this email because {{ email_reason }}.

---

{{ author }} wrote:

{{ comments|safe }}

---

To respond, please reply to this email or visit {{ url }}.

Thank you for your attention.

-- Mozilla Add-ons {{ SITE_URL }}

Is there an existing issue for this?

• [X] I have searched the existing issues

┆Issue is synchronized with this Jira Task

[wagnerand]

Note that we don't use the reviewer-reply action to ask questions, but to answer questions from the developer or send other comms that do not require review-relevant actions or information from the developer.

Questions that need to be answered in order to conclude a review are sent using a delayed rejection, so that we don't have to keep track manually of all open questions.

[abyrne-moz]

Thanks for the clarification - I've edited the ticket description to reflect this. Do you think the template suggestion I made needs to be modified as well or is it clear enough as is?

[wagnerand]

To be honest, I believe it would best to update it with a bit more neutral phrasing. We are explicitly refraining from using this action when requesting information.

Maybe something along the lines of:

A reviewer at addons.mozilla.org is reaching out on version {{ number }} of the add-on {{ name }}. You are receiving this email because {{ email_reason }}.

Please rephrase as you see fit.

[abyrne-moz]

Got it - I've updated the text in the ticket to

Hello,

A reviewer at addons.mozilla.org is contacting you regarding version {{ number }} of the add-on {{ name }}. You are receiving this email because {{ email_reason }}.

{{ author }} wrote:

{{ comments|safe }}

To respond, please reply to this email or visit {{ url }}.

Thank you for your attention.

--
Mozilla Add-ons
{{ SITE_URL }}

[ioanarusiczki]

Verified on stage