[Task]: Run CI on branches too

mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨

Other

123 stars 53 forks source link

[Task]: Run CI on branches too #14876

Open eviljeff opened 1 week ago

eviljeff commented 1 week ago

Description

With our previous circleci set-up, CI was triggered on pushes to any branch - not just master - in addition to PRs being created. With the current github actions implementation, CI is triggered on only pushes to master, in addition to PRs.

Acceptance Criteria

  ### Acceptance Criteria
  - [ ] CI runs on push to a non-master branch

Checks

[X] If the issue is ready to work on, I have removed the "needs:info" label.

┆Issue is synchronized with this Jira Task

KevinMind commented 1 week ago

Related attempt: https://github.com/mozilla/addons-server/pull/22412 trying to replace pull_request with push. Problem with this is that push only registers push to origin. So

fork, push: runs only on fork fork,pull_request: runs on addons server

There is no relationship between these two workflow runs.

It's kind of hard to explain but it might end up either not having CI related to PRs from forks, or having duplicate jobs for PRs from forks. We need to thoroughly test this.