mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨
Other
125 stars 41 forks source link

[Task]: feedback appeal decision justification to appellant(s) #14878

Closed eviljeff closed 2 months ago

eviljeff commented 3 months ago

Description

For appeal decisions arbitrary text can be provided by moderators and reviewers to justify the decision. This is more common with a denial decision but possible for an acceptance too. Either way, if it's provided we need to expose it the appellant(s) in the reply email. In most cases this is already happening but we are missing tests proving it; in some edge cases we aren't.

### Acceptance Criteria
- [x] An appeal denial from cinder with justification contains the justification in the email to the appellant(s)
- [x] An appeal denial from reviewer tools with justification contains the justification in the email to the appellant(s)
- [x] An appeal acceptance from cinder with justification contains the justification in the email to the appellant(s)
- [x] An appeal acceptance from reviewer tools with justification contains the justification in the email to the appellant(s)

Checks

┆Issue is synchronized with this Jira Task

ioanarusiczki commented 2 months ago

I must go through all scenarios from Cinder and rev tools , testing in progress.

ioanarusiczki commented 2 months ago

From rev tools (I've still to check from Cinder):

Reporter's appeal is denied, comment is a mandatory field so the email sent looks like this, it should be fine.

Reporter appeal denied from rev tools

Author appeals denied look weird, it's a compact paragraph, maybe the reviewer's comment should be on a separate line.

Author appeal is denied form revtools

another example

Another example of author appeal

ioanarusiczki commented 2 months ago

I've been looking over from Cinder too and emails sent after the appeal for disable-enable or reject-approve for extensions/themes from rev tools (without being reported) -> filed 2 followups.

What I didn't notice until now is that when "Notes" are filed in from Cinder, they'll be sent to an author together with the reason the content has been disabled. It should be fine.

Notes from Cinder