search

mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨
Other
125 stars 41 forks source link

[Bug]: themes and dictionaries can be reported for violating add-on policies #14897

Open ioanarusiczki opened 2 months ago

ioanarusiczki commented 2 months ago

What happened?

  1. A theme is reported and goes to Cinder
  2. Moderator decides to take down content
  3. After content is taken down a new report can be sent if the theme is installed in addon manager
  4. The form includes "it violates Add-on Policies"
  5. Once reported it goes in the Updated queue being flagged for human review https://reviewers.addons.allizom.org/en-US/reviewers/review/1028359

What did you expect to happen?

Not sure if that's an expected behavior - it looks like an edge case with themes and dictionaries too.

themes with addon policies

Is there an existing issue for this?

┆Issue is synchronized with this Jira Task

eviljeff commented 2 months ago

It's because once its taken down the API doesn't return information about the guid for the form to know it's a theme, and so shouldn't be offered all the categories.

If Firefox can provide this information via the AOM we can possibly workaround it with that. (It still leaves the edge case of a user reporting the guid on a browser where the add-on isn't installed)