search

mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨
Other
125 stars 41 forks source link

[Bug]: Better layout for emails sent when author's appeals are denied #14900

Open ioanarusiczki opened 2 months ago

ioanarusiczki commented 2 months ago

What happened?

From https://github.com/mozilla/addons/issues/14878 This is reproducible when appeal is denied from Cinder with Uphold decision + comment added in appeal justification field or from rev tools with Deny Appeal + add comment

Emails look like this: Author appeal is denied form revtools

What did you expect to happen?

The appeal justification coming from Cinder or comment added by an add-on reviewer should be separated.

Is there an existing issue for this?

┆Issue is synchronized with this Jira Task

eviljeff commented 2 months ago

It's tricky because we don't know if the comments will be a single sentence of a whole block of text. The original specification that legal/t&s put together specified it in-line.

ioanarusiczki commented 2 months ago

Ah ok, I wanted to add that I've noticed at approval of a version that the email has "Comments" included and maybe it would help for this case too but I didn't see specifications before filing this.

comments

KevinMind commented 2 months ago

@ioanarusiczki is the email in the screenshot actually including the lorem ipsum text? Or was that just an example?

ioanarusiczki commented 2 months ago

lorem ipsum part is user input, the comment of a reviewer in rev tools but it can also belong to a Cinder moderator.

diox commented 1 month ago

For visibility: QA also filed https://github.com/mozilla/addons/issues/14905

We think both are low priority for the moment. We can revisit when this goes live.