mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨
Other
125 stars 41 forks source link

[Bug]: 2 dots often show up in emails sent to developers #14905

Closed ioanarusiczki closed 1 month ago

ioanarusiczki commented 2 months ago

What happened?

What did you expect to happen?

The comment is sent with . at the end. If the moderator or reviewer adds it , there's also a default . which would duplicate it

the 2 dots

email sent to developer - content taken down

Is there an existing issue for this?

┆Issue is synchronized with this Jira Task

wagnerand commented 2 months ago

I am not sure where the "This is an appeal escalated from Cinder" is coming from, but it should not be part of the email sent to the developer.

ioanarusiczki commented 2 months ago

@wagnerand That is the comment added by a Cinder moderator but also the comment added by a reviewer from rev tools which is now mandatory and sent with the email at deny appeal. See also https://github.com/mozilla/addons/issues/14900

wagnerand commented 2 months ago

Thanks. Is that supposed to be inline with the template text? We should probably make that its own paragraph and indicate that it is the moderator comment.

ioanarusiczki commented 2 months ago

Ok, I added a comment for that https://github.com/mozilla/addons/issues/14900#issuecomment-2213689876

For reporter's appeals, a comment has it's own paragraph , an example is here, it's in the first screenshot.

eviljeff commented 2 months ago

Thanks. Is that supposed to be inline with the template text? We should probably make that its own paragraph and indicate that it is the moderator comment.

The DSA email templates have inline comments. Do we want all the emails to have comments in separate paragraphs?

eviljeff commented 2 months ago

Thanks. Is that supposed to be inline with the template text? We should probably make that its own paragraph and indicate that it is the moderator comment.

The DSA email templates have inline comments. Do we want all the emails to have comments in separate paragraphs?

(Though this is a different issue to the issue reported here)

abyrne-moz commented 1 month ago

A double period is not a huge issue.