mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨
Other
125 stars 41 forks source link

[Task]: Auto-close other open jobs if the add-on is already disabled #14955

Open eviljeff opened 1 month ago

eviljeff commented 1 month ago

Description

In https://github.com/mozilla/addons/issues/14928 we added auto-closing for new abuse reports when the content is already disabled. But because we route reports and appeals to different queues/teams/tools it's quite possible to have a jobs open for the same content in multiple places - yet when a decision is made to remove the content the decision is only made in one place, leaving the other jobs open.

Looking at reports for content that is already removed is wasted effort - and opens up the possibility that a different moderator makes the decision that the content does not need to be removed (e.g. it was reported under a different category of abuse, where it did not meet the threshold for removal) and we send out incorrect emails to the reporter saying we aren't going to remove it.

@wagnerand @abyrne-moz to confirm I've got this right, and to highlight any contentious parts that would need further discussion/approval.

Acceptance Criteria

### Milestones/checkpoints
- [ ] Resolving an abuse report job (with force-disable action) for an add-on in the reviewer tools closes any open cinder jobs for that add-on in cinder
- [ ] Force-disabling an add-on without resolving any cinder jobs closes any open cinder jobs.
- [ ] Resolving an abuse report job in cinder (under a policy that disables the add-on) closes any open cinder jobs, both for jobs resolvable in cinder, and in the reviewer tools.
- [ ] Appeals from reporters are also auto-closed (?)

Checks

┆Issue is synchronized with this Jira Task

diox commented 1 month ago

@abyrne-moz to double-check with other teams that this is ready to work on as part of all auto-resolving questions.