mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨

Other

125 stars 41 forks source link

[Task]: Do not expose information about an add-on being Notable or Strategic in API #14987

Open abyrne-moz opened 2 weeks ago

abyrne-moz commented 2 weeks ago

Description

In the public API, a Notable or Strategic add-on should not show its state in promoted.categories. Accordingly, the add-ons search should not return any Notable or Strategic add-ons, even if queried for that.

Acceptance Criteria

### Milestones/checkpoints
- [ ] Do not display if an add-on is `Notable` in the public API
- [ ] Do not display if an add-on is `Strategic` in the public API
- [ ] Do not allow the querying for Notable or Strategic add-ons via AMO Search

Checks

[X] If the issue is ready to work on, I have removed the "needs:info" label.
[X] If I have identified that the work is specific to a repository, I have removed "repository:addons-server" or "repository:addons-frontend"

┆Issue is synchronized with this Jira Task

eviljeff commented 2 weeks ago

@abyrne-moz to confirm, only Notable is excluded; all other promoted classes (strategic, etc) are to be exposed as now?

abyrne-moz commented 2 weeks ago

I spoke to Andreas about this, and we should exclude Strategic as well please. I'll update the description to reflect this.

wagnerand commented 2 weeks ago

What about sponsored and verified?

abyrne-moz commented 2 weeks ago

I thought these categories were no longer used and didn't apply to any current add-ons. If this is correct, is there any reason to do this? Or did I misunderstand.

eviljeff commented 2 weeks ago

Note, sponsored and verified were specifically meant to be exposed, and the presence of those promoted groups is used by frontend too, including as part of the "badged" pseudo-group. If the ask is to completely remove support for verified and sponsored please file as a separate issue, as it's a larger scope.

wagnerand commented 2 weeks ago

Note, sponsored and verified were specifically meant to be exposed, and the presence of those promoted groups is used by frontend too, including as part of the "badged" pseudo-group. If the ask is to completely remove support for verified and sponsored please file as a separate issue, as it's a larger scope.

The ask is not to remove, the ask is to be aware of the categories and make a conscious decision about them, like I did in https://github.com/mozilla/addons/issues/14980. That issue also specifies that sponsored and verified keep being exposed.

eviljeff commented 2 weeks ago

Note, sponsored and verified were specifically meant to be exposed, and the presence of those promoted groups is used by frontend too, including as part of the "badged" pseudo-group. If the ask is to completely remove support for verified and sponsored please file as a separate issue, as it's a larger scope.

The ask is not to remove, the ask is to be aware of the categories and make a conscious decision about them, like I did in #14980. That issue also specifies that sponsored and verified keep being exposed.

14980 is closed and not a dependency of this issue. If you think there is something from that issue which is relevant here - like needing to enumerate every promoted group and stating if that group should be exposed or not - can you (or Alan) update the description?