[Task]: Reviewer tools: Support attaching a zip file to a review

wagnerand commented 2 weeks ago

Description

To reduce reviewer workload by doing the same task of building an artifact for a developer to check repeatedly and to eliminate the dependency on a third-party service, the reviewer tools should support adding a zip attachment to at least rejections and reviewer replies. If it's not too much additional effort, ideally it should be supported for all actions.

Acceptance Criteria

  ### Milestones/checkpoints
  - [ ] A zip file should be attachable to at least reviewer replies and rejections, ideally all reviewer actions.

Checks

[X] If the issue is ready to work on, I have removed the "needs:info" label.
[X] If I have identified that the work is specific to a repository, I have removed "repository:addons-server" or "repository:addons-frontend"

┆Issue is synchronized with this Jira Task

diox commented 1 week ago

Let's start with a 100 MB file limit to begin with and see how it goes.

diox commented 1 week ago

Note: zip files should also go through SafeZip like all our zip files.

wagnerand commented 1 week ago

Let's do 200MB. Several dozen versions submitted just this year have XPI files larger than 100MB and at least one of them is Notable.

mozilla / addons