mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨
Other
128 stars 41 forks source link

[Task]: Show "pending" activity in devhub for all versions and not just the latest one #15024

Closed diox closed 2 months ago

diox commented 2 months ago

Description

In devhub, in the version list page, if there is a reviewer comment or any other activity needing a reply from the developer as the last activity for a version, we show a count of such activities, but only for the latest version in each channel.

Since https://github.com/mozilla/addons/issues/1981, reviewers and developers will be able to leave comments for each other on any version, so we should extend that "pending" count feature to all versions and not just the latest on each channel, allowing the developer to easily see which one needs a reply.

Acceptance Criteria

  ### Milestones/checkpoints
  - [ ] The count of "pending" activities is shown for all versions

Checks

┆Issue is synchronized with this Jira Task

diox commented 2 months ago

Easiest way to set up this scenario is to have an add-on with multiple versions in the same channel and then leave a reply on all the versions in reviewer tools.

A fancier variant: set up some versions without replies, some versions with multiple replies, some versions where the developer has replied to the reviewer, and some versions where the same reviewer reply was posted on multiple versions at the same time (https://github.com/mozilla/addons/issues/1981 allows this).

In any case the count should be shown in the version list for the add-on in devhub, and when clicking to view the replies the "unread" reviewer replies (that don't have a developer reply more recent) should be highlighted and match the count.

ioanarusiczki commented 2 months ago

Lgtm. Sending a reply from email would reset the count for a version. Or when it's replied from dev hub.

count in dev hub versions