mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨
Other
128 stars 41 forks source link

[Task]: Disable Attachments for Force Disable/Enable #15063

Closed chrstinalin closed 1 month ago

chrstinalin commented 1 month ago

Description

RE: https://github.com/mozilla/addons/issues/15018#issuecomment-2386378653 Force disable/enable are not surfaced in review history (and so its attachment is unavailable to developers). Do not allow reviewers to upload attachments under these actions to avoid confusion.

Acceptance Criteria

  ### Milestones/checkpoints
  - [ ] Reviewers should not be able to include attachments on force disable/enable actions.

Checks

┆Issue is synchronized with this Jira Task

ioanarusiczki commented 1 month ago

On dev, force disable/enable -> attachments have been removed. Looking over listed, unlisted, themes, the rest of the actions have the attachments. While looking over, I've noticed that unlisted have it for block multiple versions. I filed https://github.com/mozilla/addons/issues/15080

attachments disabled

noattachment at force enable