[Task]: reviewer tools page to process pending add-on decisions

eviljeff commented 1 month ago

Description

Once decisions can potentially not be carried out straight away (https://github.com/mozilla/addons/issues/15074) we need a a specialised review page, where the decision can be confirmed or not.

Out of scope for this initial piece of work: ability to override the decision with a different outcome - if an alternate, but still negative, decision is required it will have to be made again with the reviewer tools.

Acceptance Criteria

  ### Milestones/checkpoints
  - [ ] An add-on review page showing, at least, details of the decision that was made, and the information that it was made with.
  - [ ] Buttons to proceed with the decision, or abandon the decision

Checks

[X] If I have identified that the work is specific to a repository, I have removed "repository:addons-server" or "repository:addons-frontend"

┆Issue is synchronized with this Jira Task

ioanarusiczki commented 4 days ago

Proceed with action

email is sent to reporter and author after content is disabled. From here if the author decides to send an appeal , I've seen it being available in in T&S Escalations Queue for extensions and in Dev Themes Queues for themes.

For example for this extension https://reviewers.addons-dev.allizom.org/en-US/reviewers/review-listed/634488 The appeal sent by the author is https://stage.cinder.nonprod.webservices.mozgcp.net/job/7f9f1d5c-9e2c-44ad-be0f-4408853b43b5

For a theme https://addons-dev.allizom.org/en-US/reviewers/review-listed/633331 , the appeal sent by the author is https://stage.cinder.nonprod.webservices.mozgcp.net/job/9f79e419-d063-4b7c-b424-8fab6d118b48

Approve content instead
- works as expected, emails are sent to reporter(s)
- when reporter decides to send an appeal it would go to Cinder (same as above for proceed)

Example of a theme https://reviewers.addons-dev.allizom.org/en-US/reviewers/review/633333 and the appeal sent by the reporter is it went to cinder https://stage.cinder.nonprod.webservices.mozgcp.net/job/6bbfd453-62bb-45a8-8988-9ec07d09dc4f

Forward to Reviewer Tools
- extension/theme is forwarded to the Manual Review/ Awaiting Review queues
- from there it can be moderated , for example force-disabled/force-enabled actions used on https://reviewers.addons-dev.allizom.org/en-US/reviewers/review-listed/634489

or a theme currently in the awaiting review queue waiting for review https://reviewers.addons-dev.allizom.org/en-US/reviewers/review-listed/633178

I am not sure if at 1. the appeal is expected to be in Cinder. The other 2 choices seem to be fine.

eviljeff commented 4 days ago

I am not sure if at 1. the appeal is expected to be in Cinder. The other 2 choices seem to be fine.

Yes, Cinder.

mozilla / addons