mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨
Other
128 stars 41 forks source link

[Task]: Implement soften and harden block actions in the admin #15084

Closed diox closed 2 weeks ago

diox commented 1 month ago

Description

Follow-up from https://github.com/mozilla/addons/issues/15013

The admin should support a way to directly change a hard-blocked version to being soft-blocked and vice-versa, with full logging/confirmation like other blocklisting actions.

Acceptance Criteria

  ### Milestones/checkpoints
  - [ ] Blocks can be "hardened" in the admin
  - [ ] Blocks can be "softened" in the admin

Checks

┆Issue is synchronized with this Jira Task

diox commented 2 weeks ago

https://github.com/mozilla/addons-server/pull/22827 has some screenshots of the new UI bits. There are notably new harden/soften buttons when you're viewing a block. It should require the same permissions as for creating a block (Blocklist:Create) and the same sign-off as normal if that's a high adu (> 100k) add-on.

All the changes to the blocklist itself haven't landed, but you should be able to view the changes in the admin once processed. A hard blocked version can be softened to a soft-block, a soft-blocked version can be hardened to a hard-block.

ioanarusiczki commented 2 weeks ago

I'll try to look at this in more detail next week.

I tried it already and so far so good.

soften a block worked with https://reviewers.addons-dev.allizom.org/en-US/reviewers/review/634129 harden a block worked with https://reviewers.addons-dev.allizom.org/en-US/reviewers/review/634130

ioanarusiczki commented 1 week ago

Other test results on AMO dev:

The stash:

ioanarusiczki commented 1 week ago

Other tests on AMO dev:

Also found into a complex block submission edit submission url

Edit submission present