mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨
Other
128 stars 41 forks source link

[Task]: reviewer tools queue of pending Decisions #15085

Closed eviljeff closed 1 month ago

eviljeff commented 1 month ago

Description

Once decisions can potentially not be carried out straight away (https://github.com/mozilla/addons/issues/15074) we need a special reviewer tools queue that shows pending decisions.

Acceptance Criteria

  ### Milestones/checkpoints
  - [ ] A queue page with decisions made that haven't had their associated actions carried out yet

Checks

┆Issue is synchronized with this Jira Task

ioanarusiczki commented 1 month ago

I checked for each entity with an example today and all of them showed up in this new queue. -> an admin with "*" or an admin reviewer has access to it

new queue

The action column: -> cannot open details for users, collections or ratings (probably expected for now, idk) -> could open for extensions/themes: I did not see versions being flagged for HR or the reports presents in the DSA (idk if that's expected at this point or not )

I'll let @alexandruschek do some more exploratory: STR:

  1. report to Cinder a high profile entity (you've details about what is considered to be "high profile" here)
  2. go to the Cinder queues (depending on what's been reported)
  3. choose an action that would disable content (list of actions here)
  4. go to rev tools https://reviewers.addons-dev.allizom.org/en-US/reviewers/ Admin Tools -> Held actions for 2nd Level Approval queue
  5. make sure the high level content disabled from Cinder is now present here.
eviljeff commented 1 month ago

Add-on page will be implemented with https://github.com/mozilla/addons/issues/15075 (I just linked to the existing review page for now); review pages for other content is out of scope for this initial tranche of work (so they don't link anywhere)