search

mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨
Other
128 stars 41 forks source link

[Task]: Update Licenses available for add-on developers to choose from on AMO #15092

Closed diox closed 5 days ago

diox commented 1 month ago

Description

Following https://github.com/mozilla/addons/issues/14976 and after discussions with Legal and Product, we have settled on doing the following:

Final License order in devhub should be:

Acceptance Criteria

  ### Milestones/checkpoints
  - [ ] All Licenses names, slugs and URLs should follow [SPDX](https://spdx.org/licenses/) definition
  - [ ] New Licenses are added, with specific order in devhub
  - [ ] API docs are updated

Checks

┆Issue is synchronized with this Jira Task

leoheitmannruiz commented 1 month ago

This is awesome! Thank you.

A few questions and remarks, the most important one first:

  1. How are licenses not on this list going to be dealt with?

    GPL-3.0-or-later, for instance. Continuing to intend for people to choose "Other" and enter the name of the license seems like a bad idea. Won't this continue to allow for cases similar to the Apache-2.0 fiasco? Your plans are great improvements, but really, I feel like this is a lot more important.

  2. I'm very interested in why you decided against a way to to choose any license from SPDX.

    Was the complexity of the change this would require a major reason not to do so?

  3. Can you please elaborate on why you decided to list (only) the "only" variants of the GPL family of licenses, instead of (also) the "or-later" variants?

    I feel like your proposed license list will lead to a lot of "or-later" licensed add-ons being published as "only". It seems to me that even people applying the GPL family of licenses to their source code are often not aware of this annoying complexity. I am quite convinced that the right approach is to list both variants, so as to educate people.

  4. Have you talked about whether or not the names of licenses should be translatable?

abyrne-moz commented 1 month ago

Thanks for your follow-up!

The most popular licences were selected in collaboration with our open source licensing legal consultants. As mentioned in the previous issues, adding dozens of licence options to AMO would be unwieldy and overwhelm submitters with a multitude of unnecessary options. The Other option exists to provide a choice for any licence to be used, and for those users it is up to the submitter of the add-on to add the text for the licence.

The specific version of the licence was chosen, rather than the or later, to prevent ambiguity and ensure a specific licence is chosen.

Given that the names of the licences are proper nouns, they have not been translated at this time.

leoheitmannruiz commented 1 month ago

I'm afraid I'm lacking the skill to be able to persuade you :(

It's just a little sad to me.. I feel like you're doing something really great by allowing developers to choose a license for their source code and then you're dropping the ball right in front of the goal, by not allowing for a standardized way to choose the GPL-3.0-or-later (surely, one of the most popular licenses on AMO) and fueling the confusion of "-only" and "-or-later". And, not allowing for a standardized way of selecting all but a few very popular licenses. I'm thinking of researchers in five years, looking at how use of the BlueOak-1.0.0 evolved. But also, I'm thinking of properness and pedanticness. I don't want to see some add-ons saying "GPL 3 later", others "GPL v3 and up" and another "GPL-3-or-later", when all of them could say GPL-3.0-or-later (or the license name SPDX associates with that identifier, of course).

So, that's how I'm feeling about this, hehe.

But it seems to me that you're not keen on discussing this much longer, so I'll leave you be :)

Again, thanks for what you've already done (or are planning to do). I think they are great improvements! And, generally, thanks for taking the time!

All the best!

Given that the names of the licences are proper nouns, they have not been translated at this time.

Sorry, I should have provided more information. I assumed Mathieu Pillard was going to answer :)

Please read these two comments for the context in which I asked the question.

diox commented 1 month ago

We'll be dropping translations for all licenses as part of implementing this issue.

leoheitmannruiz commented 1 month ago

Ok!

abyrne-moz commented 1 month ago

Accidentally closed

alexandruschek commented 5 days ago

Hello, I checked this on -DEV, and according to the milestones/checpoints you have for this issue:

New Licenses are added, with specific order in devhub - the order is the same with the one mentioned in the issue:

image

The links match the ones in the description of the ticket Also, the API Documentation is updated for non-themes:

image

Only question I have before I add the label: The "Other" option should be present in the API documentation?

Thank you!

diox commented 5 days ago

For Other the slug would actually be null. This is described elsewhere in the doc, slugs are only for non-custom licenses.

alexandruschek commented 5 days ago

Oke, thank you for the info! Marking this as verified.