[Task]: Adjust auto-approval delay to take into account weekends

eviljeff commented 1 day ago

Description

We already have support for adjusting for weekends when calculating due dates - we want to implement that for auto-approval delay too.

Acceptance Criteria

  ### Milestones/checkpoints
  - [ ] An auto-approval that would fall over the weekend is adjusted to be approved after the weekend instead

Checks

[X] If I have identified that the work is specific to a repository, I have removed "repository:addons-server" or "repository:addons-frontend"

┆Issue is synchronized with this Jira Task

eviljeff commented 1 day ago

@abhn / @wagnerand can you confirm the exact criteria here: https://mozilla-hub.atlassian.net/browse/AOP-137 says "between 4pm on a Friday and 10am on the following Sunday" - this is the submission date/time, yes? i.e. the criteria isn't based on when the approval would happen, but the submission?

Sceneries for submission, assuming a 24 hour delay (configurable):

submitted at 15:59 Friday; so auto approved ~15:59 Saturday?
submitted at 16:01 Friday; so auto approved ~15:59 Monday? or ~10:01 Sunday (42 hours later)? or ~10:01 Monday (24+42 hours later)?
submitted at 10:01 Sunday; so auto approved ~10:01 Monday?

Also, these times are UTC or some other timezone?

diox commented 1 day ago

It's not explicit in this issue, but this is only about the auto-approval delay for the first listed version, right ?

Also, now that this delay is configurable if the delay is set to something higher than 24 hours, say 72 hours, could that cause a new listed add-on to have to wait 5 days in total ? Is that a problem ?

mozilla / addons