[Task]: Align BlocklistSubmission sign-off needed criteria with high impact/profile content process

eviljeff commented 1 month ago

Description

In https://github.com/mozilla/addons/issues/15074 we added criteria for certain content that would prevent an immediate action from taking place on the back of a decision. We've had sign-off criteria for blocklist submissions for a number of years, but it's quite basic - just that the blocks would cover over 100k ADU - we should align the criteria so a decision on an add-on that would be held for further evaluation, would also trigger sign-off for a block on that same add-on.

Acceptance Criteria

  ### Milestones/checkpoints
  - [ ] A blocklist submission that covers an add-on that, if a decision to disable it was made, would be held for further review would also require additional sign off.

Checks

[X] If I have identified that the work is specific to a repository, I have removed "repository:addons-server" or "repository:addons-frontend"

┆Issue is synchronized with this Jira Task

wagnerand commented 1 month ago

The sign-off on an impactful block should have happened somewhere else already, I am not sure what the value of this is.

eviljeff commented 1 month ago

The sign-off on an impactful block should have happened somewhere else already, I am not sure what the value of this is.

Can you clarify where/what the "somewhere else" is? There is currently one sign-off checkpoint for blocklist submissions, that in most cases is an auto-signoff - this issue is about changing the criteria for that auto-signoff.

wagnerand commented 1 month ago

Probably on jira or in a google doc.

diox commented 1 week ago

@wagnerand to make a proposal for how this should work

mozilla / addons