[Bug]: Delete Blocks admin page shows extra checkboxes

[diox]

What happened?

• Add a block for a guid in the admin
• Try to delete it
• The delete block page shows a checkbox for update_url_value without a label, and a checkbox for canned_reasons. There is also a None that appears at the end.

What did you expect to happen?

Not sure if the canned reasons is expected to be shown, but the one for the update url value certainly doesn't make sense to me, especially without the label. The None is likely due to the way we try to hide the delayed_until option, which doesn't make sense for delete block action.

See screenshot

Is there an existing issue for this?

• [X] I have searched the existing issues

┆Issue is synchronized with this Jira Task

[ioanarusiczki]

Yes, that's something older. I remember filing this when last time changes were done to blocklisting.

[diox]

Oh yes, absolutely, I meant to add that this is not a new thing at all, I noticed this before we started tweaking the blocklist admin. I was hoping it would fix itself as we refactored the code but it doesn't look like it will, so I've filed it.

I wasn't able to find an issue about it, but maybe it was just a comment somewhere. It's certainly not a very important issue, it's just confusing.

[ioanarusiczki]

np, couldn't find it either, maybe it was a comment after all, thanks for filing it 👍