mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨
Other
128 stars 41 forks source link

[Bug]: Delete Blocks admin page shows extra checkboxes #15146

Open diox opened 1 month ago

diox commented 1 month ago

What happened?

What did you expect to happen?

Not sure if the canned reasons is expected to be shown, but the one for the update url value certainly doesn't make sense to me, especially without the label. The None is likely due to the way we try to hide the delayed_until option, which doesn't make sense for delete block action.

See screenshot Screenshot 2024-11-06 at 14-37-57 Delete Block Django site admin

Is there an existing issue for this?

┆Issue is synchronized with this Jira Task

ioanarusiczki commented 1 month ago

Yes, that's something older. I remember filing this when last time changes were done to blocklisting.

diox commented 1 month ago

Oh yes, absolutely, I meant to add that this is not a new thing at all, I noticed this before we started tweaking the blocklist admin. I was hoping it would fix itself as we refactored the code but it doesn't look like it will, so I've filed it.

I wasn't able to find an issue about it, but maybe it was just a comment somewhere. It's certainly not a very important issue, it's just confusing.

ioanarusiczki commented 1 month ago

np, couldn't find it either, maybe it was a comment after all, thanks for filing it 👍