mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨
Other
127 stars 41 forks source link

[Bug]: Order of the entries in the `cache.json` file should be stable #15147

Closed willdurand closed 1 week ago

willdurand commented 2 weeks ago

What happened?

When the upload_mlbf_to_remote_settings CRON task creates a cache.json file, the order of the entries in each list (blocked, softblocked, notblocked) isn't stable, which means we generate different files even when nothing has changed. This makes it hard to figure out what has changed between executions since tools like sha256sum will report different hashes (and editing each file manually to sort the lists is... tedious).

What did you expect to happen?

See also: https://github.com/mozilla/addons-server/pull/22715#pullrequestreview-2418286928

Is there an existing issue for this?

┆Issue is synchronized with this Jira Task