mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨
Other
127 stars 41 forks source link

[Task]: Store all decisions for a job #15151

Open eviljeff opened 2 weeks ago

eviljeff commented 2 weeks ago

Description

Currently we expect there to be at most one decision linked a job, so if another decision occurs from an override we overwrite the existing ContentDecision instance. Aside from losing information about the previous decision (which is retained in the activity log at least), we then can't tell from the model states if a decision was overridden - a problem because we need to know if we should send different email content.

The main thing that makes this a hard change to make is the one-to-one fk is on CinderJob, and for a many-to-one from ContentDecision to CinderJob it needs to be on ContentDecision - and that means a lot of tests need updating 😐

Acceptance Criteria

  ### Milestones/checkpoints
  - [ ] A sentence describing the first milestone/checkpoint

Checks

┆Issue is synchronized with this Jira Task