mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨
Other
127 stars 41 forks source link

[Bug]: Add-ons errneously in "Held Actions for 2nd Level Approval" queue #15172

Open wagnerand opened 3 hours ago

wagnerand commented 3 hours ago

What happened?

An add-on (ID: {b15ba26a-103f-4788-a5d9-c7af17f4f763} that was ationed 4 years ago was added to the "Held Actions for 2nd Level Approval" queue. There were no reviewer actions (that are visible in the reviewer tools) from 2021 onwards.

What did you expect to happen?

This add-on likely shouldn't have been added to that queue.

Is there an existing issue for this?

┆Issue is synchronized with this Jira Task

eviljeff commented 3 hours ago

From looking in Cinder, this is what has likely happened: Someone must have logged an abuse report for it on November 14; when it's already disabled/blocked we still notify Cinder of the "decision" and create a ContentDecision instance, but don't set action_date therefore it ends up looking the same as a decision that's been held for further approval.