mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨
Other
128 stars 41 forks source link

[Task]: Track the length of time an add-on is in the review queue #15174

Open abyrne-moz opened 6 days ago

abyrne-moz commented 6 days ago

Description

Measure on a per review basis from when an add-on entered the review queue to a decision being made.

Acceptance Criteria

  ### Milestones/checkpoints
  - [ ] As a PM, I'm able to query the length of time an add-on review took, or aggregate them into averages for reporting purposes.

Checks

┆Issue is synchronized with this Jira Task

diox commented 6 days ago

Once https://github.com/mozilla/addons/issues/15072 is implemented we should be very close to having that already by looking at when the first NeedsHumanReview was created for a version compared to when it was modified: they should only be modified when is_active is flipped, which is when the review is done.

The only reason this doesn't work right now is that we mass-update multiple NHR at once when a review is done, so auto_now doesn't trigger, so modified isn't updated. But we could trivially add it ourselves.

The query would need to take into account the following things:

diox commented 6 days ago

Also specifically for DSA-related reasons, those are separate, so an add-on can be reviewed while leaving it in the queue because of those reasons