mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨
Other
128 stars 41 forks source link

[Bug]: unlisted channel - unsigned versions don't get flagged for HR when reported with abuse reports #15189

Closed ioanarusiczki closed 14 hours ago

ioanarusiczki commented 4 days ago

followup https://github.com/mozilla/addons/issues/1770

unlisted version in awaiting review is reported for abuse report with "add-on policy" https://reviewers.addons-dev.allizom.org/en-US/reviewers/review-unlisted/634333 is not flagged for hr , report for add-on policies is displayed in the dsa section

Another issue is that reports escalated from Cinder (reported with any other reason than add-on policy) don't show up in the dsa section

Example: https://stage.cinder.nonprod.webservices.mozgcp.net/job/4dceda4e-a622-4ed9-85db-d343acf5f105

What did you expect to happen?

Reports should flag the version for HR and should be available in rev tools when escalated.

@eviljeff in case I should split this in 2 (the escalation part) let me know.

Is there an existing issue for this?

eviljeff commented 4 days ago

Unlisted versions do not need to be individually reviewed as per https://github.com/mozilla/addons/issues/14985

ioanarusiczki commented 4 days ago

Shouldn't they behave as listed when not installed and reported with their guid ?

eviljeff commented 4 days ago

Shouldn't they behave as listed when not installed and reported with their guid ?

This bug doesn't specify about it not being installed - that's https://github.com/mozilla/addons/issues/15179 - is this issue a dupe?

ioanarusiczki commented 4 days ago

Sorry it is confusing, I think the first part is a dupe because signed or unsigned unlisted versions are not flagged for HR when reported for add-on policies.

Then I see for signed unlisted the same issue, escalated reports from Cinder won't be available in rev tools.

For both issues, I've sent reports using the guid (not installed in browser) because those have another rule https://github.com/mozilla/addons/issues/14985

eviljeff commented 14 hours ago

Going to dupe this to https://github.com/mozilla/addons/issues/15179#issuecomment-2498357914