mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨
Other
128 stars 41 forks source link

[Bug]: review page version activity box can get cut #15198

Open diox opened 1 week ago

diox commented 1 week ago

What happened?

STR:

Look closely at the version history in the review page: there is a visual artifact where the the text of the last activity appears to go over the border of the cell

Screenshot 2024-11-25 at 14-28-54 rabbil-rabugong-narkato – Add-ons for Firefox

(There are likely faster/easier ways to reproduce - but you probably need a single version, then enough single-line activities to be higher than the left-side column)

What did you expect to happen?

The text shouldn't go over the border like that

This is caused by enable-activity-log-attachments because when it's enabled, it adds another cell to each row of activity... but only those, the rest of the table only have 2 cells per row.

Is there an existing issue for this?

┆Issue is synchronized with this Jira Task

diox commented 1 week ago

We should either move the attachment to the second column instead of its own column, or ensure there are 3 columns for every row.

ioanarusiczki commented 6 days ago

I've seen this now on -stage at version unblocked

unblockedversion

later edit on dev

on dev

diox commented 1 day ago

A variant I saw in production, with more history (I'm only including a partial screenshot since this is prod data): Screenshot 2024-12-02 at 16-52-00 TinEye Reverse Image Search – Add-ons for Firefox