search

mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨
Other
123 stars 53 forks source link

Custom Licence name returns null for requests made in a locale different from the original set-up #1796

Open AlexandraMoga opened 5 years ago

AlexandraMoga commented 5 years ago

Similar to https://github.com/mozilla/addons/issues/5266

STR:

  1. Submit a new add-on while your locale is set to en-GB
  2. In the submission details flow, add a Custom Licence with a name of your choice
  3. After the add-on is auto-approved, get the api details of your add-on in en-US, i.e https://addons-dev.allizom.org/api/v4/addons/addon/{your-addon}/?lang=en-US
  4. Check the "license": {..."name" value

Actual result: The license name is null

Expected result: The license name should contain the value given by you during submission, regardless of the locale in which the request was made

Notes:

image

As seen on the frontend:

image

┆Issue is synchronized with this Jira Task

diox commented 5 years ago

Yes, this is not a new issue. The root cause is similar to https://github.com/mozilla/addons/issues/4000 - the model doesn't have a default_locale, and if it did it wouldn't necessarily follow the add-on's default_locale either, so that messes up cases like these.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. If you think this bug should stay open, please comment on the issue with further details. Thank you for your contributions.

AlexandraMoga commented 4 years ago

This is still a valid issue

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. If you think this bug should stay open, please comment on the issue with further details. Thank you for your contributions.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. If you think this bug should stay open, please comment on the issue with further details. Thank you for your contributions.

AlexandraMoga commented 2 years ago

Still an issue

KevinMind commented 3 months ago

Old Jira Ticket: https://mozilla-hub.atlassian.net/browse/ADDSRV-172

KevinMind commented 2 months ago

Old Jira Ticket: https://mozilla-hub.atlassian.net/browse/ADDSRV-172