search

mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨
Other
125 stars 41 forks source link

"TypeError: i.renderTo is undefined" appears after a graphic from "Statistics" page has "No data available" #1809

Open madalincm opened 5 years ago

madalincm commented 5 years ago

STR:

  1. Access AMO homepage: https://addons.allizom.org/en-US/firefox/.
  2. Click on an add-on that has the "Visit stats dashboard" link in the "More information" section. (e.g. uBlock Origin: https://addons.allizom.org/en-US/firefox/addon/ublock-origin/?src=homepage-collection-featured)
  3. Click on the "Visit stats dashboard" link in the "More information" section.
  4. Once on the "Statistics" page click on "Custom..." from the "For last:" section and select the present day.
  5. Click on any buttons from the "Group by:" or "For last:" section.

Expected result:

The statistical graphics should be displayed.

Actual result:

A "TypeError: i.renderTo is undefined" error will appear after a graphic has "No data available", which causes the following graphics to not load anymore.

Notes:

The bug is reproduced only after having a graphic with "No data available". The bug is not reproduced if graphics display data. Reproduced in amo-dev, amo-stage and amo-prod with Fx68, Win10x64. After refresh the page loads the graphics again.

2019-08-07!UNITO-UNDERSCORE!11h50!UNITO-UNDERSCORE!50

┆Issue is synchronized with this Jira Task

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. If you think this bug should stay open, please comment on the issue with further details. Thank you for your contributions.

ioanarusiczki commented 4 years ago

I see this issue reproducible on AMO dev - FF76(Win10).

reproducible

@willdurand I reopened because the issue is reproducible with beta stats too.

willdurand commented 4 years ago

I am not able to reproduce locally. I can reproduce in -dev but not locally, even with assets compiled so I dunno. I spent way too much time on this issue already.

willdurand commented 4 years ago

I am wondering if this isn't some sort of timing issue like we load data and quickly ask the app to load new data (which is empty). I cannot reproduce locally or in a test suite so I am a bit hopeless.

KevinMind commented 4 months ago

Old Jira Ticket: https://mozilla-hub.atlassian.net/browse/ADDSRV-15