Open kumar303 opened 4 years ago
Each review entry should include files and lines where they occurred. They should become links to the file viewer, on the email sent to the developer.
Currently the reviewer tools are only sending plain text emails so this won't work necessarily. Unsure if we want to break that pattern.
In any case, currently developers don't have access to the reviewer tools / code manager - so let's split this into a separate issue maybe?
Currently the reviewer tools are only sending plain text emails so this won't work necessarily. Unsure if we want to break that pattern.
In any case, currently developers don't have access to the reviewer tools / code manager - so let's split this into a separate issue maybe?
Yeah, let's start with plain text. I updated the description of this issue.
Also, just FYI, I have proposed a quick fix UI patch that will at least let reviewers copy / paste the text from Code Manager into the reviewer tools. You can see screenshots here: https://github.com/mozilla/addons-code-manager/pull/1170
Old Jira Ticket: https://mozilla-hub.atlassian.net/browse/ADDSRV-21
User story:
We have API calls to support adding comments (and some UI has landed). Next, the reviewer page needs to expose the comments and let the reviewer submit them.
In our original meeting, we had this plan:
┆Issue is synchronized with this Jira Task