search

mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨
Other
125 stars 41 forks source link

Investigate replacing our custom FxA auth with an auth lib #1847

Open eviljeff opened 2 years ago

eviljeff commented 2 years ago

Our FxA integration was added many (many) years ago and has served us well, but now we want to add some new features to it like storing refresh tokens we should take the opportunity to see if it's practical to replace it with a 3rd party library that supports FxA auth, thereby moving the complexity and maintenance out of our codebase. django-allauth is used by other Mozilla projects (e.g. Firefox Relay) so is a possible candidate.

┆Issue is synchronized with this Jira Task

eviljeff commented 2 years ago

I briefly investigated. django-allauth looks pretty good but it'd be a lot of work to squeeze our usage into how django-allauth expects to work. Implementing the features we have right now like the ability to have multiple configs (used to allow local frontend to auth against dev/stage server) would be likely require extending the classes further.

Dropping my assignment and expecting stalebot to close this in a few months.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. If you think this bug should stay open, please comment on the issue with further details. Thank you for your contributions.

KevinMind commented 4 months ago

Old Jira Ticket: https://mozilla-hub.atlassian.net/browse/ADDSRV-61