remove /api/v3/ - Githubissues

mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨

Other

127 stars 41 forks source link

remove /api/v3/ #1861

Open eviljeff opened 2 years ago

eviljeff commented 2 years ago

We updated our docs (#16300) - and made an announcement

a year ago that the v3 api will be removed at the end of 2021, so now is the time to delete support in the codebase for the v3 api, and all the shims (hacks) that keep it compatible with the current v5 api.

┆Issue is synchronized with this Jira Task

diox commented 2 years ago

I'd like to see the usage stats first - I don't want to maintain the shims forever but I'd like to make sure we don't break some old Firefoxes in a particularly nasty way for instance.

bqbn commented 2 years ago

Since 1/1/2022, we have received about 5 million requests for URIs starts with /api/v3/.

eviljeff commented 2 years ago

@diox I wasn't clear what your benchmark was for blocking this issue - was it less or more than 5 millions requests? (~131k/requests/day)

diox commented 2 years ago

Wei, can you get us a sample of those requests so we can look a little bit at what endpoints are hit, and what user-agents are hitting them ?

Also, is that for services.a.m.o. or just the main domain ? And how does that compare to usage of /api/v4 ?

eviljeff commented 2 years ago

from a search of other mozilla/ repos, the following projects reference amo's api/v3:

[x] - https://github.com/mozilla/mozilla-reports/
[x] - https://github.com/mozilla/python_mozetl/
[x] - https://github.com/mozilla/taar/ - but just in a readme
[x] - https://github.com/mozilla/taar_gcp_etl/
[x] - https://github.com/mozilla/taar_monitor/
[x] - https://github.com/mozilla/telemetry-batch-view/
[x] - https://github.com/mozilla/telemetry-dashboard/

eu9ene commented 2 years ago

All the relevant TAAR related repos are updated now.

eviljeff commented 2 years ago

All known mozilla repos referencing /api/v3/ have either been updated or are no longer in use, so if we have any remaining blocking clients they should be external ones.

KevinMind commented 6 months ago

Old Jira Ticket: https://mozilla-hub.atlassian.net/browse/ADDSRV-77

github-actions[bot] commented 1 month ago

This issue has been automatically marked as stale because it has not had recent activity. If you think this bug should stay open, please comment on the issue with further details. Thank you for your contributions.