Open wagnerand opened 2 years ago
On Matrix:
it is interesting that we are parsing the manifest before the validation tasks
these days we don't have to, we could probably refactor that away historically we needed it to see what kind of validation to run (when we supported XUL themes, search engines, things that didn't use the linter...) also, we could catch exceptions like these and raise
InvalidManifest
- that would skip that step and we'd see the linter error - just gotta be careful and ensure that it only happens for things the linter would reject
Old Jira Ticket: https://mozilla-hub.atlassian.net/browse/ADDSRV-92
(https://sentry.prod.mozaws.net/operations/olympia-prod/issues/19461815/?environment=production, olympia/files/utils.py in gecko at line 235:
return parent_block.get('gecko', {})
)Relevant manifest part:
(object holding the
gecko
key is wrapped in an array)┆Issue is synchronized with this Jira Task