search

mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨
Other
125 stars 41 forks source link

Make the Theme Wizard generate MV3 static themes #1912

Open ioanarusiczki opened 1 year ago

ioanarusiczki commented 1 year ago

As discussed with diox , I'm opening an issue:

The theme wizard is generating MV2 versions for now

MV3 is coming starting January and submission, installation and updates were tested in QA-1668

At one point in the future, the theme wizard should generate MV3 themes too.

┆Issue is synchronized with this Jira Task

eviljeff commented 1 year ago

Because of the difficultly of supporting both MV2 and MV3 versions we'll want to wait until the ESR supports MV3 at least.

eviljeff commented 1 year ago

Note: I'm unaware of anything in the MV3 spec that affects themes, so I'm assuming it's literally just changing 2 to 3 in the manifest.

KevinMind commented 4 months ago

Old Jira Ticket: https://mozilla-hub.atlassian.net/browse/ADDSRV-184

diox commented 2 weeks ago

Let's confirm that it's ok to do with web-ext folks but otherwise should be ok. We don't need to care about the existing themes yet.

willdurand commented 2 weeks ago

Let's confirm that it's ok to do with web-ext folks but otherwise should be ok. We don't need to care about the existing themes yet.

Nope, this is not OK yet... https://bugzilla.mozilla.org/show_bug.cgi?id=1917613

diox commented 2 weeks ago

:+1: we are not in a hurry to do it anyway. I've marked this as blocked, we'll want to wait for this to be fixed (and any other blockers we might discover) and probably to be rolled out in the next ESR as well...

willdurand commented 17 hours ago

https://bugzilla.mozilla.org/show_bug.cgi?id=1917613 has been fixed in Firefox 132. While it was less concerning than initially thought, we'd still recommend to use 132 as the default min version for MV3 themes.

FWIW I've uploaded a MV3 theme on -dev and everything is working flawlessly: installs, updates, etc. But we don't know what has changed between 109 (first version with MV3 support) and 132, so while themes work fine in both Release and Nightly right now, it's possible that some Firefox versions break in a more obvious (and bad) way.

Note also that MV3 dictionaries and langpacks aren't affected by Bug 1917613.