search

mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨
Other
127 stars 41 forks source link

Expand copy for content review rejection to indicate the right scope for immediate rejection #1915

Closed abhn closed 2 weeks ago

abhn commented 1 year ago

Add-ons may be rejected for violation of Mozilla acceptable use policies (https://www.mozilla.org/en-US/about/legal/acceptable-use/) in addition to serious security issues, but the copy on the radio button on content review page > admin actions reads Only use in case of serious security issues

https://github.com/mozilla/addons-server/blob/bc8368e546e5a003378df53ef74a13e5a3d1370d/src/olympia/reviewers/forms.py#L257-L258

Should it be updated to reflect the case for content/listing rejection for violation of other policies?

┆Issue is synchronized with this Jira Task

diox commented 1 year ago

@wagnerand for input

wagnerand commented 1 year ago

Yea, we can update that, but then it needs to by add-on type and review-type specific. I'm wondering about the ROI here or whether we should just remove that label entirely. Thoughts?

abhn commented 1 year ago

I like the idea of removing it entirely and documenting the differences elsewhere, like having a 'Rejections' section in our reviewer's wiki (https://wiki.mozilla.org/Add-ons/Reviewers/Guide/Reviewing)

eviljeff commented 1 year ago

@wagnerand to make a call here and either provide new copy or confirm it should be removed (or wontfix)

KevinMind commented 6 months ago

Old Jira Ticket: https://mozilla-hub.atlassian.net/browse/ADDSRV-204

wagnerand commented 2 weeks ago

Rename to "Reject immediately.".