mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨
Other
127 stars 41 forks source link

refactor where we send mlbf success ping to statsd #1955

Open eviljeff opened 1 year ago

eviljeff commented 1 year ago

Right now, because we fire a separate celery task to carry out the mlbf/stash upload to remote settings, we send the success ping to statsd after we successfully build a bloom filter, but because the upload happens. Meaning if there is a problem with the upload there is no indication in grafana - apart from the lack of the upload pings, but that can correctly occur when no upload is needed.

Options:

Note, the celery task was a deliberate change (https://github.com/mozilla/addons-server/pull/13909) because only celery workers have the required access to upload files to remote settings.

┆Issue is synchronized with this Jira Task

KevinMind commented 6 months ago

Old Jira Ticket: https://mozilla-hub.atlassian.net/browse/ADDSRV-500