search

mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨
Other
127 stars 41 forks source link

Unable to upload an addon with strict_min_version=68.2 #1976

Open danny0838 opened 9 months ago

danny0838 commented 9 months ago

Describe the problem and steps to reproduce it:

Unable to upload an add-on with browser_specific_settings.gecko.strict_min_version=68.2.

What happened?

Always gets an error Unknown "strict_min_version" 68.2 for Firefox.

What did you expect to happen?

No error should be raised.

Anything else we should know?

I come here from the other issue: https://github.com/mozilla/addons-linter/issues/5167

The current whitelist for known addon versions seems to be buggy, as an existing version 68.2 is treated as unknown.

Also the instruction of the upload UI is not user friendly. There is only a link for reporting a linter issue but no link for a mistaken validation issue.

┆Issue is synchronized with this Jira Task

diox commented 9 months ago

It's a very old version, I suspect back then it was done manually and this version, being ESR, probably slipped through the cracks.

We'll look into adding it, but be aware, if you intend to use that for a listed add-on on AMO (addons.mozilla.org), ESR doesn't send the minor version to websites, including AMO itself. So it's generally a bad idea to use a full ESR version as a strict_min_version, as AMO won't let you install it: if you're using ESR 68.2 it will believe you're actually using 68.0 and won't let you install.

danny0838 commented 9 months ago

ESR doesn't send the minor version to websites, including AMO itself. So it's generally a bad idea to use a full ESR version as a strict_min_version, as AMO won't let you install it: if you're using ESR 68.2 it will believe you're actually using 68.0 and won't let you install.

Can this be fixed?

Why using 68.2 is that the addon really breaks on 68.0 and works on 68.2 onwards.

If I use 68.0 then 68.0 will be treated as compatible but actually not. If I use 69.0 then it cannot be installed on 68.10. There's no way to make things doing right.

eviljeff commented 9 months ago

ESR doesn't send the minor version to websites, including AMO itself. So it's generally a bad idea to use a full ESR version as a strict_min_version, as AMO won't let you install it: if you're using ESR 68.2 it will believe you're actually using 68.0 and won't let you install.

Can this be fixed?

It's unlikely. I believe it was a deliberate decision for Firefox to not expose point versions to prevent user fingerprinting. (And if it was "fixed", the code wouldn't be changed in a very old version of Firefox like 68, so it wouldn't help you in this case.)

danny0838 commented 9 months ago

Seems that this issue will never get fixed. I'll simply use 68.0 although not perfect...

If you are not really going to fix it, please at least document it on MDN. Thanks.

KevinMind commented 5 months ago

Old Jira Ticket: https://mozilla-hub.atlassian.net/browse/ADDSRV-654