search

mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨
Other
125 stars 41 forks source link

'Flag review' menu has layout issues when changing screen sizes #2031

Open AlexandraMoga opened 6 years ago

AlexandraMoga commented 6 years ago

Steps to reproduce:

Prerequisites: Android device in landscape mode

1.Go to an add-on detail page and click on 'Read all reviews' (i.e. https://addons-dev.allizom.org/en-US/firefox/addon/bluhell-firewall/reviews/)

  1. Pick one of the listed reviews and tap on 'Flag'
  2. With the 'Flag' menu opened, rotate your device to portrait mode

Expected result: The 'Flag' menu is re-positioned to fit to the new screen layout

Actual result; The 'Flag' menu is cut on the right side

Notes: reproduced on all AMO servers with FF56 Android 7.0. I was not able to reproduce with RTL This also happens on Desktop on smaller screen sizes

flags

image

┆Issue is synchronized with this Jira Task

kumar303 commented 6 years ago

With the 'Flag' menu opened, rotate your device to portrait mode

I suppose it's fixable but this seems like an unrealistic thing for a user to do. They would probably begin the flagging process either in portrait mode or in landscape mode.

tofumatt commented 6 years ago

I don’t mean to be difficult but I definitely do this (switch from one orientation to another) a fair bit on my phone. I think it’s lower priority (especially as we have way more desktop users than mobile) but I think it’s worth fixing.

On 9 Nov 2017, at 00:10, Kumar McMillan notifications@github.com wrote:

With the 'Flag' menu opened, rotate your device to portrait mode

I suppose it's fixable but this seems like an unrealistic thing for a user to do. They would probably begin the flagging process either in potrait mode or in landscape mode.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

kumar303 commented 6 years ago

I switch orientation too but switching while I'm in the middle of flagging something? That seems unrealistic. I guess you could do it by accident which does happen. Anyway, there is probably an easy way to fix it.

rebmullin commented 6 years ago

right now, I see click triggering this tooltip. Would anyone be opposed to changing this to hover instead here? I think that would solve this issue...

rebmullin commented 6 years ago

never mind...I was looking at the emulator and not sure hover is really a solution for mobile

will look into this more..

codeEmpress1 commented 4 years ago

Hi, I am an outreachy applicant and I will like to work on this

willdurand commented 4 years ago

Hi, I am an outreachy applicant and I will like to work on this

@codeEmpress1 thanks for your interest in this project. You can find good first issues by looking at the opened contrib: welcome issues. This one is a bit tricky I think.

KevinMind commented 5 months ago

Old Jira Ticket: https://mozilla-hub.atlassian.net/browse/ADDFRNT-125