mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨
Other
127 stars 41 forks source link

Localized "Featured Add-On" string is still in English for all languages #2032

Open peiying2 opened 6 years ago

peiying2 commented 6 years ago

Describe the problem and steps to reproduce it:

https://addons.mozilla.org/nl/firefox/collections/mozilla/featured-add-ons/ - first reported in bug 1417120 but it looks like the issue exists in all languages

What happened?

Localized string is not displayed on production, even though the string was translated several weeks ago.

What did you expect to happen?

Localized string displayed at this prominent spot.

Anything else we should know?

https://addons.mozilla.org/nl/firefox/collections/mozilla/featured-add-ons/ (change locale code, you will see the issue is common for all locales.

┆Issue is synchronized with this Jira Task

peiying2 commented 6 years ago

@muffinresearch

muffinresearch commented 6 years ago

@peiying2 this is because these areas of the site use DB data and cannot be easily localized by the typical l10n methods. We're going to look into options for localizing this content.

peiying2 commented 5 years ago

Looks like the issue is still not fixed.

willdurand commented 5 years ago

Sorry, I closed this issue because there is no featured collection anymore.

peiying2 commented 5 years ago

Sorry, I closed this issue because there is no featured collection anymore.

Thanks for providing some background on the resolution. Let's close it then.

willdurand commented 5 years ago

I think the bug is still valid though, because we have "Recommended Extensions" now and I suppose the problem persists.

peiying2 commented 5 years ago

I thought it was just the string change of the same "feature". If that's the case, let's fix it. It is a pretty important string come to think of it, if we want users to check out what's recommended.

KevinMind commented 6 months ago

Old Jira Ticket: https://mozilla-hub.atlassian.net/browse/ADDFRNT-126