mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨
Other
127 stars 41 forks source link

We can hit the rate limit if we double-click on a rating star #2034

Open AlexandraMoga opened 6 years ago

AlexandraMoga commented 6 years ago

Update 2020-04-23: vcarciu filed https://github.com/mozilla/addons/issues/7484, which is very similar to this issue. It's a frontend bug (we should prevent double click or prevent more than 1 api call to be issued). willdurand updated this issue.


Steps to reproduce:

  1. Go to the rating section on an extension details page (https://addons-dev.allizom.org/en-US/firefox/addon/adblocker-teeesting/)
  2. Rate the add-on by double clicking on a rating star

Expected result: A suggestive message is displayed to let the user know that he attempted to post a duplicate review

Actual result: An error message which doesn't offer a clear explanation is displayed instead

Notes:Reproduced on AMO dev and stage with FF57 (Win 10, Android 7.0) Generated by #7048

image

┆Issue is synchronized with this Jira Task

ValentinaPC commented 6 years ago

This is happening also while trying to updated a developer reply. Verified on AMO-stage FF57(Android 7.2.1) Screenshot: 2017-11-29_1252

kumar303 commented 6 years ago

Rate the add-on by double clicking on a rating star

This is something we should prevent from happening. We can disable the stars after the first click.

kumar303 commented 6 years ago

Interesting. I could only reproduce this on Windows, not on Mac. I haven't tried Android.

ValentinaPC commented 6 years ago

This is also happening while clicking 2 times on the rating stars for your own add-on. First time the message is correct, second time the error is displayed. Please see video and let me know if separate tracking for this is required: thr

kumar303 commented 6 years ago

let me know if separate tracking for this is required

I don't think so because they are both caused by the same problem.

bobsilverberg commented 6 years ago

The API is returning a 429 response code to the front end, so we could potentially use that to replace the error message on the front end.

KevinMind commented 6 months ago

Old Jira Ticket: https://mozilla-hub.atlassian.net/browse/ADDFRNT-128