search

mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨
Other
125 stars 41 forks source link

Convert ReportAbuseButton to setUIState #2060

Open kumar303 opened 6 years ago

kumar303 commented 6 years ago

For QA: ensure the Report abuse button on the add-on detail page still works without regressions.

The ReportAbuseButton relies on custom actions to set internal state. These actions should be removed and replaced with setUIState.

In https://github.com/mozilla/addons/issues/2059, we will potentially have two Report abuse buttons on the same page. To support that we would need to enhance the current actions/reducers or just switch to setUIState() and set the component ID appropriately. Let's do the latter.

┆Issue is synchronized with this Jira Task

kumar303 commented 5 years ago

Some complimentary clean-up will happen in https://github.com/mozilla/addons/issues/12655

grlwholifts commented 5 years ago

hello @kumar303 , I'd like to take this up. Is this issue still available?

kumar303 commented 5 years ago

Hi @ruchikabgosain, thanks for your interest. This isn't a good issue to work on because abuse reporting might move away from https://addons.mozilla.org/ and into Firefox itself (see https://bugzilla.mozilla.org/show_bug.cgi?id=1540175). However, we aren't sure yet. I suggest looking at contrib: welcome patches as those are mostly ready to go.

grlwholifts commented 5 years ago

Okay @kumar303! Will do that 🙇

KevinMind commented 5 months ago

Old Jira Ticket: https://mozilla-hub.atlassian.net/browse/ADDFRNT-154