`blog-utils` embeds a lot of icons in the CSS

mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨

Other

127 stars 41 forks source link

`blog-utils` embeds a lot of icons in the CSS #2088

Closed willdurand closed 1 month ago

willdurand commented 3 years ago

This is kinda expected because the webpack config is written so that images are embedded in the CSS so that it is easy to import/use in addons-blog but we should probably revisit this. We should investigate how to not embed icons in the CSS anymore in blog-utils and how that would work in addons-blog and its asset pipeline.

┆Issue is synchronized with this Jira Task

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. If you think this bug should stay open, please comment on the issue with further details. Thank you for your contributions.

KevinMind commented 5 months ago

Old Jira Ticket: https://mozilla-hub.atlassian.net/browse/ADDFRNT-4

diox commented 1 month ago

Need to double-check but I think this was fixed by removing all the embeds from the CSS, though maybe blog-utils was not touched when I did that.

diox commented 1 month ago

Yeah, this was done in https://github.com/mozilla/addons/issues/14611

One small nit is that blog-utils stylesheet is referencing its own copy of the icon assets, but since it's a separate build it makes sense.