search

mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨
Other
127 stars 41 forks source link

Firefox's own Dark Mode setting not honoured by AMO - blindingly bright background #2193

Open Jackalaq opened 1 year ago

Jackalaq commented 1 year ago

As description. Dark Mode is selected in Settings and even with Dark Reader AddOn installed, the page is disturbingly bright.

Firefox for Linux Mint

Version 115

┆Issue is synchronized with this Jira Task

nekohayo commented 1 year ago

At least the about:addons UI does follow Firefox's automatic light/dark system theme; it would make a lot of sense for the addons.mozilla.org website to follow suit.

willdurand commented 1 year ago

Extensions do not run on AMO, for security reasons. And AMO doesn't have a dark mode style for the moment.

nekohayo commented 11 months ago

I think the OP mentioning the "Dark Reader add-on" was a mistake (i.e.: the key word was "even with"), and they probably primarily intended (as I did) this ticket to be a request for AMO to have a dark mode style, that would get activated by the browser's native prefers-color-scheme: dark; transmission mechanism for the OS' dark mode.

Is this the correct issue tracker for stylesheet issues of AMO? (I presume I landed here because I couldn't find this in Bugzilla)

diox commented 11 months ago

I agree this is a valid issue. (edit: and I've transferred it to a more fitting place but this was the right place to file it, thanks!)

KevinMind commented 6 months ago

Old Jira Ticket: https://mozilla-hub.atlassian.net/browse/ADDFRNT-314

i1li commented 5 months ago

The year is 2024, why does mozilla block the most basic of accessibility options, choosing instead a path of able-bodied supremacism, and white supremacism? Vision sensitivity isn't an obscure issue, does mozilla even have a dev team? Heres an example of how to honor user accessibility preferences with just a few lines of code, happy to assist with implementation: https://github.com/i1li/i1li.github.io/blob/ed2f57e824a8ad15dba59b5c4217dd06f9e1a8b2/js/script.js#L35

diox commented 5 months ago

AMO team is small and we have a limited bandwidth, we simply can't do everything. The good news is that this is open-source, so if you want to contribute a patch, feel free to submit a pull request over at https://github.com/mozilla/addons-frontend/pulls.

fiendUnpleasant commented 2 months ago

@diox "The good news is that this is open-source," is a cop out. What happens when I submit a patch that is the code as it currently stands with background=black and text=white? Will it be accepted or will you just deny the patch of the disabled person just trying get by day to day

diox commented 2 months ago

The previous commenter said they were happy to assist, so my reply was me trying to take them up on their offer.

I would gladly review a patch that implements this. It's not trivial however, there is a lot more than just one color to change. If someone really wants to give it a try rather than posting more sarcastic or aggressive comments, I have a WIP branch (that I worked on during my personal time, btw, because I do care about this issue) that could be used as a starting point.

fiendUnpleasant commented 2 months ago

@diox Hey sorry for being a dick I was in the middle of a migraine exacerbated by this issue. It's difficult to remain civil when it feels like someone is pushing an ice pick into the front of your skull. I am working with a therapist. I am not trying to excuse anything but I was wanting to have something to say for myself other than "sorry I am a dick"