Closed muffinresearch closed 8 years ago
@pwalm Are there any mocks for this? Not sure if there were and they weren't implemented properly or if we need some UX input for this bit.
No mocks, let's just expand the blue area lower with 30px of padding from the text baseline.
Hmm this one is going to be tricky. The background is a fixed height and not related to the content in terms of how the markup has been laid-out.
Failing that, we could create a new block below to house the "Contribute" section. Maybe on a different shade of dark blue or grey.
@pwalm yeah the current solution to the background is a bit of a hack so I think we'll probably find it easier to do a bit of a re-jig around the markup or some other creative approach. Background styling needs should be on a containing parent of the content otherwise it's bound to break like this.
@muffinresearch How do I get this locally? I can't seem to set up contributions locally.
If you could make my tofumatt@mozilla.com account an AMO admin on dev that might help; I can't enable the restyle for me there right now.
The easiest way to do this is to hack it via the django admin for local-dev. You can simply enable contributions there bypassing the need for the API.
Verified as fixed : http://screencast.com/t/n7LEnSDHefv
See https://addons-dev.allizom.org/en-US/firefox/addon/fireftp/?src=hp-dl-featured
See the white on white text at just below the end of the blue header background.