mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨
Other
126 stars 41 forks source link

Add back ratings and author under Theme titles #2882

Closed atsay closed 8 years ago

atsay commented 8 years ago

There used to be info underneath theme titles. I think they were star ratings, number of ratings, author, and #users (can't remember exactly). They have disappeared from the style refresh.

You can still see them on extensions: https://www.dropbox.com/s/0jcfln1hxszbjkw/Screenshot%202016-04-08%2010.00.19.png?dl=0

And here is what they look like for themes: https://www.dropbox.com/s/1uq7xtmhvmse5ho/Screenshot%202016-04-08%2010.00.25.png?dl=0

Please add them back, thanks.

andymckay commented 8 years ago

Assigning to pwalm because i think that was by design.

tofumatt commented 8 years ago

I believe dropping these was intentional on the part of UX, so we'll want their input here. :smile:

pwalm commented 8 years ago

Yep, it was intentional. We wanted to reduce the visual clutter on the page. Installing a theme is a bit different than installing an add-on: the star rating isn't a driving force for adding it to your browser.

atsay commented 8 years ago

I can see that. However, the ability to see author and number of users helps editors feature new designers. This gives new authors a quick boost and increases engagement.

Some designs display in the browser better than others, so number of users and rating can also help people make a decision on what to install.

Lastly, authors take pride in their usage and ratings, and taking them off of all category listing pages drastically reduces their visibility.

Perhaps there are enough reasons to add back just the number of users and author? It would be helpful for theme community engagement.

atsay commented 8 years ago

I understand the rationale for a cleaner look for users, but we shouldn't forget the designers who create the content for them.

pwalm commented 8 years ago

Yeah, it is based on a hypothesis, I'll cop to that. The intent is to put more focus on the theme visuals, and remove distractions and clutter. I am open to adding back the author name (it is important to recognize the contributors in an upfront way), but I'd prefer we keep the star rating and number of users displayed on the theme detail page only for the time being.

pwalm commented 8 years ago

We're going to try adding back user # as well. Will have a design ready for Monday.

pwalm commented 8 years ago

Ok, let's try something like this: img_6891

Using this text styling for the copy we're adding back: screen shot 2016-04-11 at 11 36 25 am

atsay commented 8 years ago

Looks awesome! Thanks Phillip!

tofumatt commented 8 years ago

Is there any update on this? If not I think we should close it.

atsay commented 8 years ago

Please don't close it. @pwalm -- can you provide the design?

pwalm commented 8 years ago

Is that not enough guidance above? I can give actual specs later this week, got roped into some Townhall-related design work.

tofumatt commented 8 years ago

No rush; we were doing a style refresh triage yesterday and I didn't know if this was all that was needed or not as it was style assigned to you. I figured if nothing moved on it it wasn't too important, but seems like it is 😄

Specs would be extra awesome, thanks 👍

pwalm commented 8 years ago

So let's use the same typeface and size (can't find what it is) for the user name and amount of users, but set it in regular weight and use #000000 for the colour. And not underlined/a link, obvs.

atsay commented 8 years ago

Can we prioritize this? Beyond community reasons, we should make it very clear on AMO that content is created by third-party developers and designers.

tofumatt commented 8 years ago

Prioritised! I'll aim to get this out for the next tag.

tofumatt commented 8 years ago

Also I would just like to apologise for being so slow on this and quick to close it. This is clearly an important issue and reading back on my comments I should have seen that! Fresh eyes make me realise recognising authorship is important.

Sorry! 😓

ValentinaPC commented 8 years ago

@tofumatt : After adding back the author and ratings, there are some layout issue at hover in:

  1. Themes homepage - Featured section - last row theme
  2. Themes details page - More section - last row more

Verified on AMO-dev FF47(Win 7 x64). Please let me know if this requires to be logged separately. Thanks!

ValentinaPC commented 8 years ago

Another scenario: if the user is signed out the new changes related to themes are not listed in some places (themes homepage, any theme category) Please see the screenshot: 2016-08-05_1635

tofumatt commented 8 years ago

Another scenario: if the user is signed out the new changes related to themes are not listed in some places (themes homepage, any theme category)

That seems to be a caching issue, as the HTML was updated. We'll need to force a refresh of the cache or something.

@jasonthomas Is the cache reset on dev/stage/prod after a deploy?

ValentinaPC commented 8 years ago

1. Verified as fixed for "Featured Themes" section and "More" section in AMO-dev using FF47 (Win 7 x64) (logged in or out). Postfix videos: ft more

2. Still reproducing for all themes categories in Up & Coming section, last row. (logged in or out) Please the video: theme cat

ValentinaPC commented 8 years ago

3. There is also a small display issue in Collections that only contain themes. Please see the video: collections

tofumatt commented 8 years ago

Sorry, can you give URLs to the issues? I can't reproduce.

ValentinaPC commented 8 years ago

URLs: -> Themes categories (hover over second row): https://addons-dev.allizom.org/en-US/firefox/themes/music -> Collections (containing only themes): https://addons-dev.allizom.org/en-US/firefox/collections/TesterW/only-themes/

Don't know if related to this or need to be treated separately, but for sure is related to recently themes changes, please see the right-side, cut:

atsay commented 8 years ago

Thanks Tofu & Valentina, really appreciate you getting this out.

tofumatt commented 8 years ago

@ValentinaPC Those issues are separate (and a bit longstanding IIRC), could you open a new one for them and consider this one closed?