mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨
Other
128 stars 41 forks source link

AttributeError: 'NoneType' object has no attribute 'year' #3101

Closed krupa closed 8 years ago

krupa commented 8 years ago

steps to reproduce:

  1. Log in as an admin
  2. Load https://addons.allizom.org/en-US/admin/models/waffle/switch/ or https://addons.allizom.org/admin/models/waffle/sample/

    traceback link:

https://sentry.prod.mozaws.net/operations/olympia-stage/issues/330535/

traceback details:

AttributeError: 'NoneType' object has no attribute 'year' File "django/core/handlers/base.py", line 137, in get_response response = response.render() File "django/template/response.py", line 103, in render self.content = self.rendered_content File "olympia/zadmin/init.py", line 36, in rendered_content source = loader.render_to_string(template, context_instance) File "django/template/loader.py", line 172, in render_to_string return t.render(Context(dictionary)) File "django/template/base.py", line 148, in render return self._render(context) File "newrelic/api/function_trace.py", line 98, in dynamic_wrapper return wrapped(_args, _kwargs) File "django/template/base.py", line 142, in _render return self.nodelist.render(context) File "django/template/base.py", line 844, in render bit = self.render_node(node, context) File "django/template/base.py", line 858, in render_node return node.render(context) File "django/template/loader_tags.py", line 126, in render return compiled_parent._render(context) File "newrelic/api/function_trace.py", line 98, in dynamic_wrapper return wrapped(_args, _kwargs) File "django/template/base.py", line 142, in _render return self.nodelist.render(context) File "django/template/base.py", line 844, in render bit = self.render_node(node, context) File "django/template/base.py", line 858, in render_node return node.render(context) File "newrelic/hooks/framework_django.py", line 702, in wrapper return wrapped(_args, _kwargs) File "django/template/loader_tags.py", line 65, in render result = block.nodelist.render(context) File "django/template/base.py", line 844, in render bit = self.render_node(node, context) File "django/template/base.py", line 858, in render_node return node.render(context) File "newrelic/hooks/framework_django.py", line 702, in wrapper return wrapped(_args, _kwargs) File "django/template/loader_tags.py", line 65, in render result = block.nodelist.render(context) File "django/template/base.py", line 844, in render bit = self.render_node(node, context) File "django/template/base.py", line 858, in render_node return node.render(context) File "django/template/base.py", line 1207, in render _dict = func(_resolved_args, *_resolved_kwargs) File "django/contrib/admin/templatetags/admin_list.py", line 393, in date_hierarchy } for year in years]

andymckay commented 8 years ago

It looks like https://github.com/mozilla/addons-server/blob/master/src/olympia/migrations/872-waffle-addons-linter-switch.sql does not add a date.

This was on stage: | 44 | addons-linter | 0 | Waffle switch to enable addons-linter integration for WebExtensions. | 0000-00-00 00:00:00 | 0000-00-00 00:00:00 |

I ran this: update waffle_switch set created = NOW(), modified = NOW() where id = 44;

And it works now.

Also saw this on waffle_sample:

| 4 | autosuggest-throttle | 0.0 | Percentage of search autosuggest API requests to ignore | 0000-00-00 00:00:00 | 0000-00-00 00:00:00 |

Let's be careful with those dates folks. We might need to run this on prod too.

andymckay commented 8 years ago

Jason fixed this on prod too.

madalincm commented 8 years ago

Verified as fixed in amo-dev and amo-stage in FF46(Win7) The pages are correctly loading.