Different results after refresh in search API response for relevance

mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨

Other

125 stars 41 forks source link

Different results after refresh in search API response for relevance #3531

Closed ValentinaPC closed 5 years ago

ValentinaPC commented 8 years ago

Steps to reproduce:

Make a blank search in AMO-stage https://addons.allizom.org/en-US/firefox/search/?q=&appver=48.0&platform=windows
Sort results by "Up & Coming" option
Refresh the page

Expected results: Same results are displayed.

Actual results: Different results are displayed.

Notes/Issues: Verified on FF48.0.2(Win 7). Issue is reproducing on AMO-stage and dev. Video for this issue: up coming

SVSanta commented 7 years ago

Issue also reproducible sorting by "Relevance". Videos for the issue: not the same results

EnTeQuAk commented 6 years ago

Actually closing this issue since I can no longer reproduce this, neither on -dev nor -stage nor -prod.

Please feel free to reopen at any time though.

AlexandraMoga commented 6 years ago

Actually, I can still reproduce this issue on all servers and it's now visible on the new frontend as well when filtering by 'Trending' or "Relevance'. Sometimes, you need to refresh your page twice in order to see this behavior.

If needed, we can leave this one closed and open a new case for the frontend issue.

refresh_filter

EnTeQuAk commented 6 years ago

Ah, now I can reproduce this. Alrighty, then it's really not fixed. I hope that mozilla/addons-server#7303 fixes this magically but I somehow doubt that.

This might actually be a case where requests are queued to different servers / shards over time and return different results.

diox commented 6 years ago

@AlexandraMoga can you still reproduce this?

AlexandraMoga commented 6 years ago

@diox yes, I can still reproduce the issue with both links: https://addons-dev.allizom.org/en-US/firefox/search/?sort=relevance https://addons-dev.allizom.org/en-US/firefox/search/?sort=hotness

Note that relevance needs to appear as a sort query in the URL, in order to reproduce the issue. Also, when comparing search results between relevance and hotness, there doesn't seem to be much of a difference.

diox commented 6 years ago

Ah, but there is. If the frontend is changing the parameters on its own then yes the results will be different... can you open up a new issue on addons-frontend and link this one? I'm not entirely sure the API side is fixed, but let's at least make the frontend consistent before chasing any server side bugs down...

willdurand commented 6 years ago

@diox why do you think there is a frontend issue here?

diox commented 6 years ago

Err I misread, thought the URL was changing without user interaction from ?sort=relevance to ?sort=hotness. If that's not the case then yeah, sorry, no frontend issue to see here :)

AlexandraMoga commented 6 years ago

Yes, it was always a matter of user interfering with the sort options. Sorry if it wasn't clear in the server bug. I guess the frontend bug can be closed then.

diox commented 5 years ago

I think there are 2 things going on here:

For the hotness search, that's probably because of the low user count on dev, as well as https://github.com/mozilla/addons/issues/5091 which we're wontfixing because static themes don't have the same problem.
For the relevancy search, that's probably https://github.com/mozilla/addons/issues/6112

Keeping this open for now to track it, we'll see how we're doing once mozilla/addons#6112 is fixed and static themes are all "hotter".

diox commented 5 years ago

Closing since mozilla/addons#6112 is fixed and mozilla/addons#5091 tracks the hotness issue.