mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨
Other
127 stars 41 forks source link

[l18n]"Continue to download" button breaks the layout for featured add-ons section at hover #3857

Closed ValentinaPC closed 6 years ago

ValentinaPC commented 7 years ago

Steps to reproduce:

  1. Load AMO-stage homepage and change the language to French https://addons.allizom.org/fr/firefox/
  2. Go to an add-on category (https://addons.allizom.org/fr/firefox/extensions/language-support/) that has an add-on with "Continue to download" button and hover over

Expected results: There are no display or layout issues.

Actual results: The add-on with "Continue to download" button is causing layout issues.

Notes/Issues: Reproducing all around AMO servers. I think is because of the length of the button label. Verified on FF50.1(Win 7 x64). Screenshot for this issue: fr

wagnerand commented 7 years ago

The mentor for this bug is: @tofumatt

If this is your first contribution, please refer to https://wiki.mozilla.org/Add-ons/Contribute/Code on how to get started.

totaki commented 7 years ago

You was right, it because final width button more than parent width. First simple changes at more shorted message :). More difficult solution from change CSS.

tsl143 commented 7 years ago

@ValentinaPC Does this still exist?

screen shot 2017-07-20 at 3 52 39 pm
ValentinaPC commented 7 years ago

@tsl143 : Yes. But, you have to have an add-on that has a "Continue to download" button instead of an "Add to Firefox" as we can see in your screenshot. Please access https://addons.allizom.org/fr/firefox/extensions/language-support/ and hover over "gtranslate" add-on. Screenshot: fr

Thanks for your reply!

tsl143 commented 7 years ago

Got it, thanks for clarification :)

ValentinaPC commented 7 years ago

Anytime!

tsl143 commented 7 years ago

This issue also replicates with Download button on chrome and other browsers.

screen shot 2017-08-21 at 6 19 26 pm screen shot 2017-08-21 at 6 19 05 pm
eviljeff commented 6 years ago

This page/feature has been rewritten in our new front-end and the problem reported in this issue is fixed there, or is no longer applicable. Bugs with our new front-end can be filed at https://github.com/mozilla/addons-frontend/issues/new