search

mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨
Other
126 stars 41 forks source link

Account settings is not completely RTL #4416

Closed vcarciu closed 7 years ago

vcarciu commented 7 years ago

Steps to reproduce: 1.Login to AMO Stage and select Account Settings (https://addons.allizom.org/en-US/firefox/users/edit) 2.Set the language to any RTL language (ie. https://addons.allizom.org/ar/firefox/users/edit)

Expected results: The entire page is in RTL

Actual results: Info for every section is not RTL

Please see video for this issue: rtlaccountssettings

zawadm commented 7 years ago

I am working to fix it.

eviljeff commented 7 years ago

@zawadm Hi, are you still working on this? You're welcome to but we should warn you that these pages are being replaced later this year with https://github.com/mozilla/addons-frontend/

tsl143 commented 7 years ago

Also I find written fuzzy infront of the translate strings, does that mean something(I am not sure how translation works for this)

screen shot 2017-07-23 at 10 43 44 pm
muffinresearch commented 7 years ago

This will be going away in Q4 so should be a low priority - if there's a fix in progress then it's ok to continue.

@tsl143 the fuzzy marker is there because the translation is a "fuzzy" match for the english key. This translation will not be used until a translator has a chance to update and fix the translation. When they do that they would typically remove the fuzzy marker. It's a useful feature since this often gives a localizer a headstart on a translation.

wagnerand commented 7 years ago

@tsl143 Did you have any chance to work on this yet? If not, maybe another issue might be better to take since the current design is going away quite soon which makes this issue obsolete. Of course, if you have something already, feel free to send it our way, please :)

tsl143 commented 7 years ago

@wagnerand I am not working on this right now.

wagnerand commented 7 years ago

No problem, we're closing this then.