mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨
Other
127 stars 41 forks source link

Contradiction between a webextension compatibility and “Compatible with Firefox 57+” label #4635

Closed vasilicatamas closed 7 years ago

vasilicatamas commented 7 years ago

Steps to reproduce:

  1. Try to install the following webextension on Firefox 56 or Firefox 57: https://addons.mozilla.org/en-US/firefox/addon/xtense-we/?src=search

Expected results: I’m not sure which should be the expected result here but I’m thinking about 2 options:

  1. “Compatible with Firefox 57+” label is not displayed for webextensions with strict_max_version < 57.0
  2. Force all webextension to have at least strict_max_version = 57.0

Actual results: The webextension is not installed because it is not compatible with Firefox 56 or Firefox 57 which contradicts “Compatible with Firefox 57+” label. This issue can be very confusing for the users.

Additional notes:

wagnerand commented 7 years ago

Nice edge case you found there.

It's a webextension but it has a "strict_max_version": "54.0".

jvillalobos commented 7 years ago

strict_max_version usually doesn't make any sense for add-ons using WebExtensions. Most of the time, we should be telling the developer not to do that. In the rare cases where it makes sense, I think it's an edge case we can accept.