Automatically insert a MPL LICENSE file

davidhedlund commented 7 years ago

Describe the problem and steps to reproduce it:

The most popular license on AMO is MPL 2.0.

What happened?

Most of them do not ship with a LICENSE at all.

What did you expect to happen?

It would be convenient if you could suggest a automatic way to insert https://www.mozilla.org/media/MPL/2.0/index.txt into LICENSE when the authors upload new versions.
Also, it would be very useful to verify if a LICENSE file exist in the API. Example: https://addons.mozilla.org/api/v3/addons/addon/popup-blocker/. Then we don't have to download add-ons, extract them, and look for LICENSE.

Anything else we should know?

The Free Software Directory (https://directory.fsf.org/wiki/Free_Software_Directory:IceCat_WebExtensions_(proposed)) don't approve add-ons that are said to be distributed under MPL on AMO but doesn't ship with a copy of the license.

jvillalobos commented 7 years ago

Automatically changing files in add-ons is error-prone, so we don't do it unless strictly necessary, which isn't the case here.

Adding a linter warning about the LICENCE file if the add-on has one of the preset open source licenses could be useful, though. @wagnerand, @kewisch thoughts?

As for exposing the presence of the file in the API, I think that's too specific.

diox commented 7 years ago

Adding a linter warning about the LICENCE file if the add-on has one of the preset open source licenses could be useful, though. @wagnerand, @kewisch thoughts?

It'd be nice, but the licence choice happens after validation in the submission flow (both for new submissions and updates) so the only warning we can add really is just a generic "Your add-on does not contain a LICENCE file" at validation time, without knowing what licence will be chosen later in the process.

jvillalobos commented 7 years ago

For updates we at least know what was chosen for the previous version, which will most likely remain the same for the new version. I'm not opposed to a generic notice, though, since most add-ons claim to be open-source.

wagnerand commented 7 years ago

I mostly agree with @jvillalobos although I don't believe it warrants a validation warning. We have to be careful to not overload developers with warnings, otherwise we risk that they start ignoring them.

https://developer.mozilla.org/en-US/Add-ons/Listing already mentions a license in general, we could add a note about including LICENSE files in the add-on.

davidhedlund commented 7 years ago

@wagnerand

https://developer.mozilla.org/en-US/Add-ons/Listing already mentions a license in general, we could add a note about including LICENSE files in the add-on.

Yes, that is a good idea. Can you add it (The GPL licenses recommends a COPYING file.)?

jvillalobos commented 7 years ago

Okay, let's not bother with the validation warning now. Nothing left to do in code, then.

davidhedlund commented 7 years ago

@jvillalobos Its been very painful to spend endless of hours to verify if a copy of the license file exists in each add-on for the add-on repository I'm building for GNU IceCat.

Can you please at least make a recommendation message display? If your server don't find a copy of a license file then you could send a message to the owner of the add-on during the upload process. So for example, for add-ons released under your most popular license, Mozilla Public License (MPL) 2.0, you could show this message.

We recommend that save https://www.mozilla.org/media/MPL/2.0/index.txt as file name LICENSE in the root directory.

Again, I've been working hundreds of hours on IceCats add-on list and I'm tired of contacting the add-on owners each time. Its extremely impractical to force other people to do it when you can encourage the add-on owners to do this properly.

Also, regarding https://github.com/mozilla/addons/issues/4734

https://developer.mozilla.org/en-US/Add-ons/Listing already mentions a license in general, we could add a note about including LICENSE files in the add-on.

Can you please do that?

jvillalobos commented 7 years ago

Again, I've been working hundreds of hours on IceCats add-on list and I'm tired of contacting the add-on owners each time.

I'm sorry you have to do that, but we need to balance various factors and decided this isn't worth doing. Adding too much messaging during the submission process makes developers less likely to pay attention to the most critical ones.

Can you please do that?

It's a wiki, so anyone can do that. I'm pretty busy myself, so I can't help you with that.

davidhedlund commented 6 years ago

I would like Mozilla to add a license file to all 256 add-ons in https://addons.mozilla.org/en-US/firefox/user/mozilla/#my-submissions

mozilla / addons