search

mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨
Other
127 stars 41 forks source link

API provides & as & in collection description #5199

Closed muffinresearch closed 6 years ago

muffinresearch commented 6 years ago

Looks like there's an escaping issue on the collections page [1] , the api appears to provide it with an encoded ampersand [2].

dynamic_media_downloaders_ _add-ons_for_firefox

[1] https://addons.allizom.org/en-US/firefox/collections/mozilla/dynamic-media-downloaders/ [2] https://addons.allizom.org/api/v3/accounts/account/mozilla/collections/dynamic-media-downloaders/

eviljeff commented 6 years ago

Hmm. We don't do anything special with description before serializing it. Is this the only place the API is returning & pre-encoded for inclusion in html?

muffinresearch commented 6 years ago

@eviljeff if this happens elsewhere it's probably a bug too, I wouldn't expect the API to have assumed anything about the context of usage in general (albeit there are cases where the API does supply HTML, but I don't think this is one of them).

muffinresearch commented 6 years ago

Closing in favour of https://github.com/mozilla/addons/issues/11352