No dictionary for "German" availible on the new AMO page

[Etamuk]

I did a clean install of firefox 56.0.2. So i wanted to install the german dictionary. I went to "Addons" and got the new Addons-Page. But on this new site i couldn't find the german dictionary. On the old site it is still available. Please see my screenshots. I hope the german dictionaries will be copied to the new site.

New site:

Old site:

[tofumatt]

They are still available but it seems out new site's mapping is missing some dictionaries. I'll have a look into why this is. Thanks for filing!

[muffinresearch]

@tofumatt when you have a moment please could you investigate this and see why the data is different?

[tofumatt]

The data returned is correct (I think) but we use the languages in Firefox's own languages.json which should have all known langs to us in it. This lets us organise the dictionaries like the old site does... it seems something isn't mapping and being omitted.

[muffinresearch]

@tofumatt is this something that could be in next week's milestone?

[tofumatt]

As in landed for today? I can certainly give it a go!

• Matt (Sent from mobile)

On 7 Nov 2017, at 13:02, Stuart Colville notifications@github.com wrote:

@tofumatt is this something that could be in next week's milestone?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[muffinresearch]

As in landed for today? I can certainly give it a go!

@tofumatt "next week" as-in next week's push rather than this week's push. :)

[RickieES]

Just for the record, is proper bug nettiquete to close always the latter bugs filed, not the first one.

[tofumatt]

Usually it’s best to just close the bug with the least info 😅

[RickieES]

Both bugs have the same amount of info, if you look at them. OP in this issue mentions German as missing, issue #523 mentions all es-* variants missing and some other languages missing at the top of the table. Both bugs mention where the problem may be (the JSON used to build the list).

The only extra information in this issue is that the AMO team does the triage late in the bug fix, the first you must do with a bug is search if it is a duplicate.

I just want the bug fixed, I'm not looking for recognition through my bug prevailing (I don't need or want that recognition after +15 years contributing Mozilla). I'm just pointing that bug triaging and marking for duplicates was the first task within a bug in Mozilla for a reason, which is avoiding duplicate issues going forward in parallel by different people in the team or outside of it.

[tofumatt]

I just checked the response data and it looks like the target_locale for a lot of the german-language dictionaries, etc, are things like "target_locale": "de-DE" not "target_locale": "de". Might be this is messing up our filtering. I'm logging this here as I'm going away on holiday tomorrow and will only be working on this for a bit of time on the train. 😄

[tofumatt]

Figured out a fix for this and have it working, just need to write a few tests and then we're golden.

[Speravir]

I noticed this issue for German, too, but didn't know first, where to leave a message. But I also noticed that other languages are also affected, not just Spanish like in the closed ticket. Because according to rumours the now legacy design is going not to be available in some days I did a comparison (something that should in my opinion have be done by someone of the developers before setting the new design as default …). Not present in new design, many of them may be automatically displayed again after the mentioned patch is applied, but for some it is not obvious for me, why they are hidden (note that I looked with Fx 56.x):

• Acholi (UG) Language Pack
• Akan Spelling Dictionary
• Amharic Spell Checker
• Corrector ortografico aragonés (Aragonese dictionary)
• Armenian (hy-AM) Language Pack and
  Armenian spell checker dictionary
• Assamese (IN) Language Pack and
  Lachit - an Assamese Spell Checker
• Azerbaijani (AZ) Language Pack and
  Azerbaijani Spell Checker
• Беларуская Language Pack,
  Belarusian Dictionary and
  Belarusian Classic Dictionary
• Bengali (India) Language Pack
• Bosanski Language Pack (Bosnian)
• Breton Language Pack for Firefox and
  Difazier An Drouizig (Breton/Brezonheg dictionary)
• Firefox en valencià (Valencian Catalan language pack, AVL version),
  Diccionario ortográfico valenciano (myspell version) and
  Diccionari valencià (AVL version)
• Chichewa Spell Check
• Hrvatski (HR) Language Pack (Croatian),
  Croatian Dictionary - Hrvatski Rjecnik and
  Croatian Dictionary (Hrvatski Rjecnik) (hr-HR)
• Diccionario Papiamento (pap-AW) and
  Dikshonario Papiamentu (pap-CW)
• English (Australian) Dictionary
• Canadian English Dictionary
• New Zealand English Dictionary
• English (South African) Language Pack
• Esperanto Language Pack and
  Esperanta Vortaro
• Eesti (et) keele pakk (Estonian language pack) and
  Eesti keele speller (Estonian dictionary)
• Eʋegbe Spelling Dictionary
• Faroese Spell Checker (Faroe Islands)
• Dizionari Furlan (Friulian)
• Pulaar Fulfulde Language Pack (Fulah)
• Corrector de Galego (Galician)
• German (Austria): German Dictionary, extended for Austria (by KaiRo) and
  German dictionary (de_AT) (by B. Jacke)
• German (Germany): German Dictionary (KaiRO, new spelling),
  German dictionary (de_DE) (B. Jacke, new spelling) and
  German Dictionary, classical spelling standards (T. Kuban)
• German (Swiss): German Dictionary (Switzerland) (KaiRo) and
  German dictionary (de_CH) (B. Jacke)
• English - Greek Spelling dictionary
• Gujarati (IN) Language Pack and
  Gujarati Spell Checker (India)
• Haitian Creole spell checker
• Hausa Spelling Dictionary
• Hawaiian spell checker
• Hiligaynon spell checker
• Hindi Language Pack and
  Hindi Spell Checker
• Icelandic (IS) Language Pack and
  Icelandic Dictionary
• Interlingue Spell Checker
• Taqbaylit Language Pack (Kabyle)
• Kannada (IN) Language Pack and
  Kannada Spell Checker – Add-ons for Firefox
• Kashubian Spell Checker (Poland)
• Kazakh (KZ) Language Pack
• ខ្មែរ Language Pack (Khmer)
• Rastnivîs (Kurdish)
• Lao Spellchecking Dictionary
• Latin Dictionary
• saskarnes latviskojums (Latvian language pack) and
  Latviešu valodas pareizrakstibas parbaudes vardnica (Latvian spell checker)
• Lingala spell checker (Hunspell ln-CD) – Add-ons for Firefox
• Lietuviu Language Pack and
  Lithuanian spelling check dictionary
• Maithili Language Pack
• Malagasy Spell Checker
• Te Papakupu Maori ( Maori/Aotearoa)
• Marathi Language Pack and
  Marathi Dictionary
• Ndebele (South) spell checker (isiNdebele)
• Nepali Dictionary
• Northern Sotho spell checker (Sepedi)
• Correcteur Occitan-Languedocien
• Oriya (OR) Language Pack,
  Oriya Spell Checker and
  Odia Spelling Checker (or-IN)
• Lilak, Persian Spell Checker Dictionary (another spell checker and a language pack are already displayed under F for Farsi)
• Punjabi (Gurmukhi) Language Pack and
  Punjabi Spell Checker
• Rumantsch Language Pack (Romansh, not to be confused up with Romanian)
• Sanskrit Spell Checker
• српски (sr) Language Pack (Serbian), Srpski (spell checker by dekss) and
  Српски речник - Serbian Dictionary (by Љуб. Радовановић)
• Sinhala (LK) Language Pack
• Swati spell checker (Siswati/Swazi)
• Soŋay Language Pack and
  Soŋay senni hantum tenjandikaw (Songai spell checker)
• Southern Sotho spell checker (Sesotho)
• Spanish (Argentina): Español (AR) Language Pack and
  Diccionario español Argentina
• Spanish (Chile): Pack de idioma Español (Chile)
• Spanish (Mexico): Español (México) Language Pack,
  Diccionario español México (by eduardo_moreno) and
  Diccionario de Español/México (by Mozilla México, E. Rios, odinmojica)
• Spanish (Spain): Español (España) Language Pack and
  Diccionario de Español/España
• Spanish (Venezuela): Diccionario en español para Venezuela
• Kiswahili Spell Checker (sw-TZ)
• Tamil Language Pack and
  Tamil Spell Checker for Firefox
• Tamil (India): ThamiZha! Solthiruthi(Tamil spellchecker)
• Tsonga spell checker (Xitsonga)
• Tswana spell checker (Setswana)
• Turkmen spell checker dictionary
• Uzbek Language Pack and
  Uzbek Spell Checker (Uzbekistan)
• Venda spell checker
• Venetan (spell checker)
• Cymraeg Language Pack (Welsh) and
  Geiriadur Cymraeg (spell checker)
• Xhosa spell checker (isiXhosa)
• Yiddish spell checker (YIVO)
• Zulu spell checker

Also several language packs marked as incompatible are not displayed, but they should be made available at least after setting some compatibility switch (well, this is generally missing at the moment):

• Akan Language Pack for Firefox
• Aragonese Language Pack
• Firefox en valenciano (Valencian Catalan language pack)
• Fijian Language Pack – Add-ons for Firefox
• Furlan Language Pack
• Kashubian (CSB) Language Pack
• Kurdish (Ku) Language Pack
• Ligure (Zeneize) Language Pack
• Luganda (UG) Language Pack
• Malagasy (MG) Language Pack
• Malayalam (IN) Language Pack
• Ndebele Language Pack
• Northern Sotho (Sesotho sa Leboa/Sepedi) Language Pack
• Swazi Language Pack
• Southern Sotho Language Pack
• Kiswahili (SW) Language Pack
• Kiswahili (SW-TZ) Language Pack
• Tamil (Sri Lanka): Tamil (LK) Language Pack (Outdated) and
  Tamil (ta-LK) Language Pack
• Tsonga Language Pack
• Tswana Language Pack
• Venda Language Pack
• Walloon Language Pack
• Wolof (Senegal) Language Pack
• Xhosa Language Pack
• Zulu Language Pack

BTW more glitches:

• Why is Albanian sorted as Shqip under S, but Finnish as Suomi under F? (The latter is the mistake I assume.) The same for Magyar (Hungarian) under H. Why is Монгол (Mongol) before Melayu?
• Why sometimes there is a translation (I am German as you guessed), but most of the entries do not have one? This is different in the legacy list.

[muffinresearch]

@tofumatt This seems to be an issue that's coming up quite frequently. Is your patch available somewhere so it can be picked up and finished off?

[tofumatt]

Yeah it’s nearly ready and I can totally push a finished version today.

• Matt (Sent from mobile)

On 14 Nov 2017, at 10:52, Stuart Colville notifications@github.com wrote:

@tofumatt This seems to be an issue that's coming up quite frequently. Is your patch available somewhere so it can be finished off?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[muffinresearch]

Yeah it’s nearly ready and I can totally push a finished version today.

@tofumatt If this the branch, then we can look to get it ready to save interrupting your time off any more than necessary? https://github.com/mozilla/addons-frontend/tree/language-tools-not-shown-addons/528

[tofumatt]

Yup, that's the one. Just pushed a few tweaks to it; there are a few failing tests but easy to fix up. It works on the page though, should just be a matter of tweaking tests. Thanks for taking care of that, sorry I didn't get to it in time! 😄

[AlexandraMoga]

Verified on AMO-dev FF56 and FF57 (Win 10) Results: the new alphabetical sorting based on English vocabulary is working as expected and missing dictionaries have been added to the list: @muffinresearch : on the old pages, there are 150 languages listed, while on the new front-end there are 125. Differences occur also for Android listings. Is there a reason for having this discrepancy?

[muffinresearch]

@AlexandraMoga I'll check that out.

[RickieES]

I've just tested https://addons.mozilla.org/en-US/firefox/language-tools/ with Firefox 56, Firefox 58 and 59, and still can't see the Spanish dictionaries (German appears as Deutsch, but only as language pack). Other Spanish users with Firefox 57 reports the same problem.

[muffinresearch]

@RickieES that's because it's not released yet. It's going out today (Thursday) at around 9am Pacific.

[muffinresearch]

@AlexandraMoga there are some language packs for locales we don't have represented in the languages list at all, I'm going to file a separate issue to cover that so it can be dealt with in due course.

[AlexandraMoga]

Thanks, @muffinresearch I'm marking this as verified fixed based on the above comment.