search

mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨
Other
127 stars 41 forks source link

No dictionary for "German" availible on the new AMO page #528

Closed Etamuk closed 6 years ago

Etamuk commented 7 years ago

I did a clean install of firefox 56.0.2. So i wanted to install the german dictionary. I went to "Addons" and got the new Addons-Page. But on this new site i couldn't find the german dictionary. On the old site it is still available. Please see my screenshots. I hope the german dictionaries will be copied to the new site.

New site: bildschirmfoto vom 2017-11-05 19-11-47

Old site: bildschirmfoto vom 2017-11-05 19-12-54

tofumatt commented 7 years ago

They are still available but it seems out new site's mapping is missing some dictionaries. I'll have a look into why this is. Thanks for filing!

muffinresearch commented 7 years ago

@tofumatt when you have a moment please could you investigate this and see why the data is different?

tofumatt commented 7 years ago

The data returned is correct (I think) but we use the languages in Firefox's own languages.json which should have all known langs to us in it. This lets us organise the dictionaries like the old site does... it seems something isn't mapping and being omitted.

muffinresearch commented 7 years ago

@tofumatt is this something that could be in next week's milestone?

tofumatt commented 7 years ago

As in landed for today? I can certainly give it a go!

On 7 Nov 2017, at 13:02, Stuart Colville notifications@github.com wrote:

@tofumatt is this something that could be in next week's milestone?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

muffinresearch commented 7 years ago

As in landed for today? I can certainly give it a go!

@tofumatt "next week" as-in next week's push rather than this week's push. :)

RickieES commented 7 years ago

Just for the record, is proper bug nettiquete to close always the latter bugs filed, not the first one.

tofumatt commented 7 years ago

Usually it’s best to just close the bug with the least info 😅

RickieES commented 7 years ago

Both bugs have the same amount of info, if you look at them. OP in this issue mentions German as missing, issue #523 mentions all es-* variants missing and some other languages missing at the top of the table. Both bugs mention where the problem may be (the JSON used to build the list).

The only extra information in this issue is that the AMO team does the triage late in the bug fix, the first you must do with a bug is search if it is a duplicate.

I just want the bug fixed, I'm not looking for recognition through my bug prevailing (I don't need or want that recognition after +15 years contributing Mozilla). I'm just pointing that bug triaging and marking for duplicates was the first task within a bug in Mozilla for a reason, which is avoiding duplicate issues going forward in parallel by different people in the team or outside of it.

tofumatt commented 7 years ago

I just checked the response data and it looks like the target_locale for a lot of the german-language dictionaries, etc, are things like "target_locale": "de-DE" not "target_locale": "de". Might be this is messing up our filtering. I'm logging this here as I'm going away on holiday tomorrow and will only be working on this for a bit of time on the train. 😄

tofumatt commented 7 years ago

Figured out a fix for this and have it working, just need to write a few tests and then we're golden.

Speravir commented 6 years ago

I noticed this issue for German, too, but didn't know first, where to leave a message. But I also noticed that other languages are also affected, not just Spanish like in the closed ticket. Because according to rumours the now legacy design is going not to be available in some days I did a comparison (something that should in my opinion have be done by someone of the developers before setting the new design as default …). Not present in new design, many of them may be automatically displayed again after the mentioned patch is applied, but for some it is not obvious for me, why they are hidden (note that I looked with Fx 56.x):

Also several language packs marked as incompatible are not displayed, but they should be made available at least after setting some compatibility switch (well, this is generally missing at the moment):

BTW more glitches:

muffinresearch commented 6 years ago

@tofumatt This seems to be an issue that's coming up quite frequently. Is your patch available somewhere so it can be picked up and finished off?

tofumatt commented 6 years ago

Yeah it’s nearly ready and I can totally push a finished version today.

On 14 Nov 2017, at 10:52, Stuart Colville notifications@github.com wrote:

@tofumatt This seems to be an issue that's coming up quite frequently. Is your patch available somewhere so it can be finished off?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

muffinresearch commented 6 years ago

Yeah it’s nearly ready and I can totally push a finished version today.

@tofumatt If this the branch, then we can look to get it ready to save interrupting your time off any more than necessary? https://github.com/mozilla/addons-frontend/tree/language-tools-not-shown-addons/528

tofumatt commented 6 years ago

Yup, that's the one. Just pushed a few tweaks to it; there are a few failing tests but easy to fix up. It works on the page though, should just be a matter of tweaking tests. Thanks for taking care of that, sorry I didn't get to it in time! 😄

AlexandraMoga commented 6 years ago

Verified on AMO-dev FF56 and FF57 (Win 10) Results: the new alphabetical sorting based on English vocabulary is working as expected and missing dictionaries have been added to the list: image @muffinresearch : on the old pages, there are 150 languages listed, while on the new front-end there are 125. Differences occur also for Android listings. Is there a reason for having this discrepancy?

muffinresearch commented 6 years ago

@AlexandraMoga I'll check that out.

RickieES commented 6 years ago

I've just tested https://addons.mozilla.org/en-US/firefox/language-tools/ with Firefox 56, Firefox 58 and 59, and still can't see the Spanish dictionaries (German appears as Deutsch, but only as language pack). Other Spanish users with Firefox 57 reports the same problem.

muffinresearch commented 6 years ago

@RickieES that's because it's not released yet. It's going out today (Thursday) at around 9am Pacific.

muffinresearch commented 6 years ago

@AlexandraMoga there are some language packs for locales we don't have represented in the languages list at all, I'm going to file a separate issue to cover that so it can be dealt with in due course.

AlexandraMoga commented 6 years ago

Thanks, @muffinresearch I'm marking this as verified fixed based on the above comment.